This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
fix(installer): MONGODB_HOST should hardcode mongo #9656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: realanna <anna.reale@dynatrace.com>
RealAnna
added
the
CI:trigger-build-everything
Signed-off-by: realanna <anna.reale@dynatrace.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9656 +/- ##
=======================================
Coverage 70.90% 70.91%
=======================================
Files 618 618
Lines 32735 32735
Branches 1645 1645
=======================================
+ Hits 23211 23214 +3
+ Misses 8278 8276 -2
+ Partials 1246 1245 -1 see 1 file with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
thisthat
approved these changes
May 2, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
as mentioned in #9527 we removed the name-override from MongoDB so this should be hardcoded in the MONGODB_HOST env var. This var will not cause any problem for external DBs since those are connected via external_connection_string
Related Issues
Fixes #9526 (comment)
How to test
https://github.com/keptn/keptn/actions/runs/4858605537