feat(lifecycle-operator): add namespace to deploymentduration metri…

…cs (#3292) Signed-off-by: Pim Merks <pimmerks@users.noreply.github.com>
keptn · Mar 19, 2024 · 0735e31 · 0735e31
1 parent 15717bd
commit 0735e31
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 0 deletions.
diff --git a/lifecycle-operator/apis/lifecycle/v1beta1/keptnappversion_types.go b/lifecycle-operator/apis/lifecycle/v1beta1/keptnappversion_types.go
@@ -311,6 +311,7 @@ func (a KeptnAppVersion) GetMetricsAttributes() []attribute.KeyValue {
 func (a KeptnAppVersion) GetDurationMetricsAttributes() []attribute.KeyValue {
 	return []attribute.KeyValue{
 		common.AppName.String(a.Spec.AppName),
+		common.AppNamespace.String(a.Namespace),
 		common.AppVersion.String(a.Spec.Version),
 		common.AppPreviousVersion.String(a.Spec.PreviousVersion),
 	}

diff --git a/lifecycle-operator/apis/lifecycle/v1beta1/keptnappversion_types_test.go b/lifecycle-operator/apis/lifecycle/v1beta1/keptnappversion_types_test.go
@@ -151,6 +151,7 @@ func TestKeptnAppVersion(t *testing.T) {
 
 	require.Equal(t, []attribute.KeyValue{
 		common.AppName.String("appname"),
+		common.AppNamespace.String("namespace"),
 		common.AppVersion.String("version"),
 		common.AppPreviousVersion.String("prev"),
 	}, app.GetDurationMetricsAttributes())

diff --git a/lifecycle-operator/apis/lifecycle/v1beta1/keptnworkloadversion_types.go b/lifecycle-operator/apis/lifecycle/v1beta1/keptnworkloadversion_types.go
@@ -311,6 +311,7 @@ func (w KeptnWorkloadVersion) GetDurationMetricsAttributes() []attribute.KeyValu
 	return []attribute.KeyValue{
 		common.AppName.String(w.Spec.AppName),
 		common.WorkloadName.String(w.Spec.WorkloadName),
+		common.WorkloadNamespace.String(w.Namespace),
 		common.WorkloadVersion.String(w.Spec.Version),
 		common.WorkloadPreviousVersion.String(w.Spec.PreviousVersion),
 	}

diff --git a/lifecycle-operator/apis/lifecycle/v1beta1/keptnworkloadversion_types_test.go b/lifecycle-operator/apis/lifecycle/v1beta1/keptnworkloadversion_types_test.go
@@ -141,6 +141,7 @@ func TestKeptnWorkloadVersion(t *testing.T) {
 	require.Equal(t, []attribute.KeyValue{
 		common.AppName.String("appname"),
 		common.WorkloadName.String("workloadname"),
+		common.WorkloadNamespace.String("namespace"),
 		common.WorkloadVersion.String("version"),
 		common.WorkloadPreviousVersion.String("prev"),
 	}, workload.GetDurationMetricsAttributes())