chore(lifecycle-operator): remove unused FailAction parameter from Ke…

…ptnEvaluation (#3138) Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
keptn · Feb 28, 2024 · 4febd99 · 4febd99
1 parent a7c0b86
commit 4febd99
Show file tree

Hide file tree

Showing 7 changed files with 0 additions and 13 deletions.
diff --git a/.github/scripts/.helm-tests/default/result.yaml b/.github/scripts/.helm-tests/default/result.yaml
@@ -2149,8 +2149,6 @@ spec:
                 type: string
               evaluationDefinition:
                 type: string
-              failAction:
-                type: string
               retries:
                 default: 10
                 type: integer

diff --git a/.github/scripts/.helm-tests/lifecycle-only/result.yaml b/.github/scripts/.helm-tests/lifecycle-only/result.yaml
@@ -2095,8 +2095,6 @@ spec:
                 type: string
               evaluationDefinition:
                 type: string
-              failAction:
-                type: string
               retries:
                 default: 10
                 type: integer

diff --git a/.github/scripts/.helm-tests/lifecycle-with-certs/result.yaml b/.github/scripts/.helm-tests/lifecycle-with-certs/result.yaml
@@ -2125,8 +2125,6 @@ spec:
                 type: string
               evaluationDefinition:
                 type: string
-              failAction:
-                type: string
               retries:
                 default: 10
                 type: integer

diff --git a/docs/docs/reference/api-reference/lifecycle/v1beta1/index.md b/docs/docs/reference/api-reference/lifecycle/v1beta1/index.md
@@ -557,7 +557,6 @@ _Appears in:_
 | `evaluationDefinition` _string_ | EvaluationDefinition refers to the name of the KeptnEvaluationDefinition which includes the objectives for the KeptnEvaluation. The KeptnEvaluationDefinition can be located in the same namespace as the KeptnEvaluation, or in the Keptn namespace. || x |
 | `retries` _integer_ | Retries indicates how many times the KeptnEvaluation can be attempted in the case of an error or missed evaluation objective, before considering the KeptnEvaluation to be failed. |10| ✓ |
 | `retryInterval` _[Duration](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.28/#duration-v1-meta)_ | RetryInterval specifies the interval at which the KeptnEvaluation is retried in the case of an error or a missed objective. |5s| ✓ |
-| `failAction` _string_ |  || ✓ |
 | `checkType` _string_ | Type indicates whether the KeptnEvaluation is part of the pre- or postDeployment phase. || ✓ |
 
 

diff --git a/lifecycle-operator/apis/lifecycle/v1beta1/keptnevaluation_types.go b/lifecycle-operator/apis/lifecycle/v1beta1/keptnevaluation_types.go
@@ -58,8 +58,6 @@ type KeptnEvaluationSpec struct {
 	// +kubebuilder:validation:Type:=string
 	// +optional
 	RetryInterval metav1.Duration `json:"retryInterval,omitempty"`
-	// +optional
-	FailAction string `json:"failAction,omitempty"`
 	// Type indicates whether the KeptnEvaluation is part of the pre- or postDeployment phase.
 	// +optional
 	Type common.CheckType `json:"checkType,omitempty"`

diff --git a/lifecycle-operator/chart/templates/keptnevaluation-crd.yaml b/lifecycle-operator/chart/templates/keptnevaluation-crd.yaml
@@ -79,8 +79,6 @@ spec:
                 type: string
               evaluationDefinition:
                 type: string
-              failAction:
-                type: string
               retries:
                 default: 10
                 type: integer

diff --git a/lifecycle-operator/config/crd/bases/lifecycle.keptn.sh_keptnevaluations.yaml b/lifecycle-operator/config/crd/bases/lifecycle.keptn.sh_keptnevaluations.yaml
@@ -463,8 +463,6 @@ spec:
                   The KeptnEvaluationDefinition can be
                   located in the same namespace as the KeptnEvaluation, or in the Keptn namespace.
                 type: string
-              failAction:
-                type: string
               retries:
                 default: 10
                 description: |-