fix(metrics-operator): flaky test in SLI converter (#1954)

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
keptn · Aug 25, 2023 · cadb170 · cadb170
1 parent a8d6902
commit cadb170
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/metrics-operator/converter/sli_converter_test.go b/metrics-operator/converter/sli_converter_test.go
@@ -14,7 +14,7 @@ indicators:
   throughput: "builtin:service.requestCount.total:merge(0):count?scope=tag(keptn_project:$PROJECT),tag(keptn_stage:$STAGE),tag(keptn_service:$SERVICE),tag(keptn_deployment:$DEPLOYMENT)"
   response_time_p95: "builtin:service.response.time:merge(0):percentile(95)?scope=tag(keptn_project:$PROJECT),tag(keptn_stage:$STAGE),tag(keptn_service:$SERVICE),tag(keptn_deployment:$DEPLOYMENT)"`
 
-const expectedOutput = `---
+const expectedOutput1 = `---
 apiVersion: metrics.keptn.sh/v1alpha3
 kind: AnalysisValueTemplate
 metadata:
@@ -25,7 +25,9 @@ spec:
     name: dynatrace
     namespace: keptn
   query: builtin:service.response.time:merge(0):percentile(95)?scope=tag(keptn_project:{{.project}}),tag(keptn_stage:{{.stage}}),tag(keptn_service:{{.service}}),tag(keptn_deployment:{{.deployment}})
----
+`
+
+const expectedOutput2 = `---
 apiVersion: metrics.keptn.sh/v1alpha3
 kind: AnalysisValueTemplate
 metadata:
@@ -108,7 +110,10 @@ func TestConvertSLI(t *testing.T) {
 	// happy path
 	res, err = c.Convert([]byte(sliContent), "dynatrace", "keptn")
 	require.Nil(t, err)
-	require.Equal(t, expectedOutput, res)
+	// need to check the result with contains, as there is no guarantee
+	// of order of the AnalysisValueTemplates in resulting manifest
+	require.Contains(t, res, expectedOutput1)
+	require.Contains(t, res, expectedOutput2)
 }
 
 func TestConvertQuary(t *testing.T) {