-
Notifications
You must be signed in to change notification settings - Fork 109
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(operator): use List() when fetching KeptnWorkloadInstances for …
…KeptnAppVersion (#1456) Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
- Loading branch information
Showing
5 changed files
with
283 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
220 changes: 220 additions & 0 deletions
220
operator/controllers/lifecycle/keptnappversion/reconcile_workloadstate_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,220 @@ | ||
| package keptnappversion | ||
|
|
||
| import ( | ||
| "context" | ||
| "testing" | ||
|
|
||
| lfcv1alpha3 "github.com/keptn/lifecycle-toolkit/operator/apis/lifecycle/v1alpha3" | ||
| apicommon "github.com/keptn/lifecycle-toolkit/operator/apis/lifecycle/v1alpha3/common" | ||
| "github.com/stretchr/testify/require" | ||
| v1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/apimachinery/pkg/types" | ||
| ) | ||
|
|
||
| //nolint:dogsled | ||
| func TestKeptnAppVersionReconciler_reconcileWorkloads_noWorkloads(t *testing.T) { | ||
| appVersion := &lfcv1alpha3.KeptnAppVersion{ | ||
| ObjectMeta: v1.ObjectMeta{ | ||
| Name: "appversion", | ||
| Namespace: "default", | ||
| }, | ||
| Spec: lfcv1alpha3.KeptnAppVersionSpec{ | ||
| AppName: "app", | ||
| }, | ||
| } | ||
| r, _, _, _ := setupReconciler(appVersion) | ||
|
|
||
| state, err := r.reconcileWorkloads(context.TODO(), appVersion) | ||
| require.Nil(t, err) | ||
| require.Equal(t, apicommon.StateSucceeded, state) | ||
|
|
||
| err = r.Client.Get(context.TODO(), types.NamespacedName{Namespace: appVersion.Namespace, Name: appVersion.Name}, appVersion) | ||
| require.Nil(t, err) | ||
| require.Equal(t, apicommon.StateSucceeded, appVersion.Status.WorkloadOverallStatus) | ||
| require.Len(t, appVersion.Status.WorkloadStatus, 0) | ||
| } | ||
|
|
||
| //nolint:dogsled | ||
| func TestKeptnAppVersionReconciler_reconcileWorkloads(t *testing.T) { | ||
| appVersion := &lfcv1alpha3.KeptnAppVersion{ | ||
| ObjectMeta: v1.ObjectMeta{ | ||
| Name: "appversion", | ||
| Namespace: "default", | ||
| }, | ||
| Spec: lfcv1alpha3.KeptnAppVersionSpec{ | ||
| KeptnAppSpec: lfcv1alpha3.KeptnAppSpec{ | ||
| Workloads: []lfcv1alpha3.KeptnWorkloadRef{ | ||
| { | ||
| Name: "workload", | ||
| Version: "ver1", | ||
| }, | ||
| }, | ||
| }, | ||
| AppName: "app", | ||
| }, | ||
| } | ||
| r, _, _, _ := setupReconciler(appVersion) | ||
|
|
||
| // No workloadInstances are created yet, should stay in Pending state | ||
|
|
||
| state, err := r.reconcileWorkloads(context.TODO(), appVersion) | ||
| require.Nil(t, err) | ||
| require.Equal(t, apicommon.StatePending, state) | ||
|
|
||
| err = r.Client.Get(context.TODO(), types.NamespacedName{Namespace: appVersion.Namespace, Name: appVersion.Name}, appVersion) | ||
| require.Nil(t, err) | ||
| require.Equal(t, apicommon.StatePending, appVersion.Status.WorkloadOverallStatus) | ||
| require.Len(t, appVersion.Status.WorkloadStatus, 1) | ||
| require.Equal(t, []lfcv1alpha3.WorkloadStatus{ | ||
| { | ||
| Workload: lfcv1alpha3.KeptnWorkloadRef{ | ||
| Name: "workload", | ||
| Version: "ver1", | ||
| }, | ||
| Status: apicommon.StatePending, | ||
| }, | ||
| }, appVersion.Status.WorkloadStatus) | ||
|
|
||
| // Creating WorkloadInstace that is not part of the App -> should stay Pending | ||
|
|
||
| wi1 := &lfcv1alpha3.KeptnWorkloadInstance{ | ||
| ObjectMeta: v1.ObjectMeta{ | ||
| Name: "workload", | ||
| Namespace: "default", | ||
| }, | ||
| Spec: lfcv1alpha3.KeptnWorkloadInstanceSpec{ | ||
| KeptnWorkloadSpec: lfcv1alpha3.KeptnWorkloadSpec{ | ||
| AppName: "app2", | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| err = r.Client.Create(context.TODO(), wi1) | ||
| require.Nil(t, err) | ||
|
|
||
| state, err = r.reconcileWorkloads(context.TODO(), appVersion) | ||
| require.Nil(t, err) | ||
| require.Equal(t, apicommon.StatePending, state) | ||
|
|
||
| err = r.Client.Get(context.TODO(), types.NamespacedName{Namespace: appVersion.Namespace, Name: appVersion.Name}, appVersion) | ||
| require.Nil(t, err) | ||
| require.Equal(t, apicommon.StatePending, appVersion.Status.WorkloadOverallStatus) | ||
| require.Len(t, appVersion.Status.WorkloadStatus, 1) | ||
| require.Equal(t, []lfcv1alpha3.WorkloadStatus{ | ||
| { | ||
| Workload: lfcv1alpha3.KeptnWorkloadRef{ | ||
| Name: "workload", | ||
| Version: "ver1", | ||
| }, | ||
| Status: apicommon.StatePending, | ||
| }, | ||
| }, appVersion.Status.WorkloadStatus) | ||
|
|
||
| // Creating WorkloadInstance of App with progressing state -> appVersion should be Progressing | ||
|
|
||
| wi2 := &lfcv1alpha3.KeptnWorkloadInstance{ | ||
| ObjectMeta: v1.ObjectMeta{ | ||
| Name: "app-workload-ver1", | ||
| Namespace: "default", | ||
| }, | ||
| Spec: lfcv1alpha3.KeptnWorkloadInstanceSpec{ | ||
| KeptnWorkloadSpec: lfcv1alpha3.KeptnWorkloadSpec{ | ||
| AppName: "app", | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| err = r.Client.Create(context.TODO(), wi2) | ||
| require.Nil(t, err) | ||
|
|
||
| err = r.Client.Get(context.TODO(), types.NamespacedName{Namespace: wi2.Namespace, Name: wi2.Name}, wi2) | ||
| require.Nil(t, err) | ||
|
|
||
| wi2.Status.Status = apicommon.StateProgressing | ||
| err = r.Client.Update(context.TODO(), wi2) | ||
| require.Nil(t, err) | ||
|
|
||
| state, err = r.reconcileWorkloads(context.TODO(), appVersion) | ||
| require.Nil(t, err) | ||
| require.Equal(t, apicommon.StateProgressing, state) | ||
|
|
||
| err = r.Client.Get(context.TODO(), types.NamespacedName{Namespace: appVersion.Namespace, Name: appVersion.Name}, appVersion) | ||
| require.Nil(t, err) | ||
| require.Equal(t, apicommon.StateProgressing, appVersion.Status.WorkloadOverallStatus) | ||
| require.Len(t, appVersion.Status.WorkloadStatus, 1) | ||
| require.Equal(t, []lfcv1alpha3.WorkloadStatus{ | ||
| { | ||
| Workload: lfcv1alpha3.KeptnWorkloadRef{ | ||
| Name: "workload", | ||
| Version: "ver1", | ||
| }, | ||
| Status: apicommon.StateProgressing, | ||
| }, | ||
| }, appVersion.Status.WorkloadStatus) | ||
|
|
||
| // Updating WorkloadInstance of App with succeeded state -> appVersion should be Succeeded | ||
|
|
||
| err = r.Client.Get(context.TODO(), types.NamespacedName{Namespace: wi2.Namespace, Name: wi2.Name}, wi2) | ||
| require.Nil(t, err) | ||
|
|
||
| wi2.Status.Status = apicommon.StateSucceeded | ||
| err = r.Client.Update(context.TODO(), wi2) | ||
| require.Nil(t, err) | ||
|
|
||
| state, err = r.reconcileWorkloads(context.TODO(), appVersion) | ||
| require.Nil(t, err) | ||
| require.Equal(t, apicommon.StateSucceeded, state) | ||
|
|
||
| err = r.Client.Get(context.TODO(), types.NamespacedName{Namespace: appVersion.Namespace, Name: appVersion.Name}, appVersion) | ||
| require.Nil(t, err) | ||
| require.Equal(t, apicommon.StateSucceeded, appVersion.Status.WorkloadOverallStatus) | ||
| require.Len(t, appVersion.Status.WorkloadStatus, 1) | ||
| require.Equal(t, []lfcv1alpha3.WorkloadStatus{ | ||
| { | ||
| Workload: lfcv1alpha3.KeptnWorkloadRef{ | ||
| Name: "workload", | ||
| Version: "ver1", | ||
| }, | ||
| Status: apicommon.StateSucceeded, | ||
| }, | ||
| }, appVersion.Status.WorkloadStatus) | ||
| } | ||
|
|
||
| //nolint:dogsled | ||
| func TestKeptnAppVersionReconciler_handleUnaccessibleWorkloadInstanceList(t *testing.T) { | ||
| appVersion := &lfcv1alpha3.KeptnAppVersion{ | ||
| ObjectMeta: v1.ObjectMeta{ | ||
| Name: "appversion", | ||
| Namespace: "default", | ||
| }, | ||
| Spec: lfcv1alpha3.KeptnAppVersionSpec{ | ||
| KeptnAppSpec: lfcv1alpha3.KeptnAppSpec{ | ||
| Workloads: []lfcv1alpha3.KeptnWorkloadRef{ | ||
| { | ||
| Name: "workload", | ||
| Version: "ver1", | ||
| }, | ||
| }, | ||
| }, | ||
| AppName: "app", | ||
| }, | ||
| } | ||
| r, _, _, _ := setupReconciler(appVersion) | ||
|
|
||
| err := r.handleUnaccessibleWorkloadInstanceList(context.TODO(), appVersion) | ||
| require.Nil(t, err) | ||
|
|
||
| err = r.Client.Get(context.TODO(), types.NamespacedName{Namespace: appVersion.Namespace, Name: appVersion.Name}, appVersion) | ||
| require.Nil(t, err) | ||
| require.Equal(t, apicommon.StateUnknown, appVersion.Status.WorkloadOverallStatus) | ||
| require.Len(t, appVersion.Status.WorkloadStatus, 1) | ||
| require.Equal(t, []lfcv1alpha3.WorkloadStatus{ | ||
| { | ||
| Workload: lfcv1alpha3.KeptnWorkloadRef{ | ||
| Name: "workload", | ||
| Version: "ver1", | ||
| }, | ||
| Status: apicommon.StateUnknown, | ||
| }, | ||
| }, appVersion.Status.WorkloadStatus) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters