Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(operator): bootstrapped KeptnAppCreationRequest CRD #1134

Merged
merged 7 commits into from
Mar 31, 2023

Conversation

bacherfl
Copy link
Member

Closes #612

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@github-actions github-actions bot added documentation Improvements or additions to documentation helm operator labels Mar 28, 2023
@netlify
Copy link

netlify bot commented Mar 28, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 2373f2e
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64228f02254a480008b64f2e
😎 Deploy Preview https://deploy-preview-1134--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #1134 (6a18c30) into main (559acee) will increase coverage by 0.02%.
The diff coverage is 50.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1134      +/-   ##
==========================================
+ Coverage   59.05%   59.07%   +0.02%     
==========================================
  Files         126      128       +2     
  Lines       10023    10031       +8     
==========================================
+ Hits         5919     5926       +7     
- Misses       3888     3890       +2     
+ Partials      216      215       -1     
Impacted Files Coverage Δ
...r/apis/lifecycle/v1alpha3/zz_generated.deepcopy.go 0.00% <ø> (ø)
...rs/lifecycle/keptnappcreationrequest/controller.go 33.33% <33.33%> (ø)
...ifecycle/v1alpha3/keptnappcreationrequest_types.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 64.15% <ø> (ø)
component-tests 60.83% <ø> (+0.21%) ⬆️
lifecycle-operator 78.48% <50.00%> (-0.05%) ⬇️
metrics-operator 77.35% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl bacherfl marked this pull request as ready for review March 28, 2023 07:49
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bacherfl bacherfl merged commit 6b58da3 into keptn:main Mar 31, 2023
@bacherfl bacherfl deleted the feat/612/kacr branch March 31, 2023 07:58
@keptn-bot keptn-bot mentioned this pull request Mar 31, 2023
nlamirault pushed a commit to nlamirault/lifecycle-toolkit that referenced this pull request Apr 3, 2023
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation helm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bootstrap KeptnAppCreationRequest
3 participants