Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metrics-operator): normalize Dynatrace URL #1145

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

thisthat
Copy link
Member

Signed-off-by: Giovanni Liva giovanni.liva@dynatrace.com

Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
@netlify
Copy link

netlify bot commented Mar 29, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit fe7a2c2
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6423fb69c969e200078cd6f1
😎 Deploy Preview https://deploy-preview-1145--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Mar 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #1145 (fe7a2c2) into main (e118851) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1145   +/-   ##
=======================================
  Coverage   59.05%   59.05%           
=======================================
  Files         126      126           
  Lines       10023    10033   +10     
=======================================
+ Hits         5919     5925    +6     
- Misses       3887     3891    +4     
  Partials      217      217           
Impacted Files Coverage Δ
...ontrollers/common/providers/dynatrace/dynatrace.go 81.66% <100.00%> (+3.66%) ⬆️

... and 3 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 64.15% <ø> (ø)
component-tests 59.75% <ø> (-1.08%) ⬇️
lifecycle-operator 78.52% <ø> (ø)
metrics-operator 77.57% <100.00%> (+0.22%) ⬆️
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mowies mowies changed the title chore(metrics-operator): normalize Dynatrace URL fix(metrics-operator): normalize Dynatrace URL Mar 29, 2023
@thisthat thisthat merged commit b33b4f4 into keptn:main Mar 29, 2023
@keptn-bot keptn-bot mentioned this pull request Mar 29, 2023
nlamirault pushed a commit to nlamirault/lifecycle-toolkit that referenced this pull request Mar 29, 2023
aepfli pushed a commit to aepfli/lifecycle-toolkit that referenced this pull request Mar 30, 2023
nlamirault pushed a commit to nlamirault/lifecycle-toolkit that referenced this pull request Apr 3, 2023
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants