Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make examples resource footprint smaller, fix bugs #1171

Merged
merged 2 commits into from
Apr 3, 2023
Merged

feat: make examples resource footprint smaller, fix bugs #1171

merged 2 commits into from
Apr 3, 2023

Conversation

mowies
Copy link
Member

@mowies mowies commented Apr 3, 2023 •
edited
Loading

This PR

  • fixes a bug in the examples makefile where a missing namespace broke the setup
  • reduces the resource footprint for o11y support software
  • reduces the resource footprint of the podtato-head example app by removing the legs
  • makes use of https://github.com/mock-server/mockserver instead of prometheus to mock metrics

@mowies
feat: make examples resource footprint smaller, fix bugs
daba0dd 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@netlify
Copy link

netlify bot commented Apr 3, 2023

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit daba0dd
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/642a8b7be3a8a60008416990
😎 Deploy Preview https://deploy-preview-1171--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mowies
add examples to semantic PR checker
cd83188 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@github-actions github-actions bot added the ops label Apr 3, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mowies mowies merged commit 8b165d3 into keptn:main Apr 3, 2023
@mowies mowies deleted the more-examples-fixes branch April 3, 2023 09:32
@keptn-bot keptn-bot mentioned this pull request Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisthat thisthat thisthat approved these changes

@RealAnna RealAnna RealAnna approved these changes

@thschue thschue Awaiting requested review from thschue

@bacherfl bacherfl Awaiting requested review from bacherfl

@philipp-hinteregger philipp-hinteregger Awaiting requested review from philipp-hinteregger

Assignees
No one assigned
Labels
ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mowies @thisthat @RealAnna