Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(operator): look up latest AppVersion based on creation timestamp #1186

Merged
merged 5 commits into from
Apr 6, 2023

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Apr 5, 2023

Closes #1185

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@netlify
Copy link

netlify bot commented Apr 5, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 50155c8
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/642e64d41c7550000812f8aa
😎 Deploy Preview https://deploy-preview-1186--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #1186 (50155c8) into main (c164595) will decrease coverage by 0.41%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1186      +/-   ##
==========================================
- Coverage   59.03%   58.63%   -0.41%     
==========================================
  Files         128      114      -14     
  Lines       10050     9493     -557     
==========================================
- Hits         5933     5566     -367     
+ Misses       3899     3753     -146     
+ Partials      218      174      -44     
Impacted Files Coverage Δ
...lers/lifecycle/keptnworkloadinstance/controller.go 82.62% <100.00%> (-0.34%) ⬇️

... and 25 files with indirect coverage changes

Flag Coverage Δ
certificate-operator ?
lifecycle-operator ?
metrics-operator 77.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl bacherfl marked this pull request as ready for review April 5, 2023 12:30
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Apr 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bacherfl bacherfl merged commit 45a96e7 into keptn:main Apr 6, 2023
@bacherfl bacherfl deleted the fix/keptn-app-version-lookup branch April 6, 2023 08:33
@keptn-bot keptn-bot mentioned this pull request Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WorkloadInstance Controller: Change lookup of latest matching KeptnAppVersion to consider creation timestamp
3 participants