Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(operator): propagate KeptnTaskDefinition labels and annotations to Job Pods #1283

Merged
merged 3 commits into from
Apr 26, 2023
Merged

feat(operator): propagate KeptnTaskDefinition labels and annotations to Job Pods #1283

merged 3 commits into from
Apr 26, 2023

Conversation

odubajDT
Copy link
Contributor

Fixes: #885

…to Job Pods

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #1283 (c18d0b4) into main (00fd1f3) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1283      +/-   ##
==========================================
+ Coverage   59.75%   59.79%   +0.04%     
==========================================
  Files         138      138              
  Lines       10444    10462      +18     
==========================================
+ Hits         6241     6256      +15     
- Misses       3968     3970       +2     
- Partials      235      236       +1     
Impacted Files Coverage Δ
operator/apis/lifecycle/v1alpha3/common/common.go 100.00% <100.00%> (ø)
...r/apis/lifecycle/v1alpha3/keptnappversion_types.go 97.64% <100.00%> (+0.02%) ⬆️
...perator/apis/lifecycle/v1alpha3/keptntask_types.go 97.59% <100.00%> (ø)
.../lifecycle/v1alpha3/keptnworkloadinstance_types.go 95.41% <100.00%> (+0.04%) ⬆️
.../controllers/lifecycle/keptntask/function_utils.go 79.13% <100.00%> (+0.94%) ⬆️

... and 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 64.15% <ø> (ø)
component-tests 59.60% <100.00%> (-0.08%) ⬇️
lifecycle-operator 78.34% <100.00%> (+0.06%) ⬆️
metrics-operator 77.80% <ø> (ø)
scheduler 21.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT marked this pull request as ready for review April 26, 2023 09:23
@odubajDT odubajDT requested a review from a team as a code owner April 26, 2023 09:23
mowies
mowies previously approved these changes Apr 26, 2023
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

@odubajDT odubajDT merged commit 83be9d9 into keptn:main Apr 26, 2023
34 checks passed
@keptn-bot keptn-bot mentioned this pull request Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add labels and annotations to Job Pods
3 participants