Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve docs for KeptnEvaluationDefinition #1335

Merged
merged 3 commits into from
May 3, 2023

Conversation

thisthat
Copy link
Member

@thisthat thisthat commented May 2, 2023

Fixes #1334

Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 2, 2023
@netlify
Copy link

netlify bot commented May 2, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit dbf7911
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6450bbb50a072400082a2a8a
😎 Deploy Preview https://deploy-preview-1335--keptn-lifecycle-toolkit.netlify.app/docs/concepts/evaluations
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented May 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@thisthat thisthat marked this pull request as ready for review May 2, 2023 08:55
@thisthat thisthat requested review from a team as code owners May 2, 2023 08:55
@StackScribe
Copy link
Contributor

StackScribe commented May 2, 2023

This conflicts with #1224:

  • 1224 deletes the concepts/evaluations page
  • Replaces it with the yaml-crd-ref/evaluationdefinition.md and yaml-crd-ref/evaluationprovider.md files, which have been updated for the v1alpha3 information.
  • The content you added in lines 37-39 was not in 1224 but is now added
  • I also added the example yaml file in the "Examples" section of the page.

Additional information in #1317 and #1337 . Those are still works in progress but eventually I'll be sure that salient information from those getting started guides are incorporated into the yaml-crd-ref and implementing files.

I think this PR should be closed and we should use the version in 1224

@thisthat thisthat merged commit d9e0aac into keptn:main May 3, 2023
@thisthat thisthat deleted the docs/1334/remove-kep branch May 3, 2023 08:43
@keptn-bot keptn-bot mentioned this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove KeptnEvaluationProvider
4 participants