docs: refactor contributing guide - linter requirements #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yash Pimple <97302447+YashPimple@users.noreply.github.com>
github-actions
bot
added
the
documentation
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
agardnerIT
previously approved these changes
May 14, 2023
|
Does this replace #1387? If so, please close #1387.
Other than that, great job and a nice small PR (easy to review so that's great). LGTM. |
|
Hi @agardnerIT, |
StackScribe
approved these changes
Jun 1, 2023
StackScribe
previously approved these changes
Jun 1, 2023
aepfli
reviewed
Jun 1, 2023
Signed-off-by: Yash Pimple <yashpimple22@gmail.com>
mowies
reviewed
Jun 5, 2023
Signed-off-by: Yash Pimple <yashpimple22@gmail.com>
StackScribe
previously approved these changes
Jun 8, 2023
mowies
reviewed
Jun 12, 2023
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
mowies
previously approved these changes
Jun 12, 2023
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
mowies
changed the title
mowies
changed the title
mowies
approved these changes
Jun 12, 2023
StackScribe
approved these changes
Jun 12, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Merged
StackScribe
added a commit
to StackScribe/lifecycle-toolkit
that referenced
this pull request
Jun 19, 2023
Signed-off-by: Yash Pimple <97302447+YashPimple@users.noreply.github.com> Signed-off-by: Yash Pimple <yashpimple22@gmail.com> Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> Co-authored-by: Meg McRoberts <DreidelLhasa@yahoo.com> Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
StackScribe
added a commit
to StackScribe/lifecycle-toolkit
that referenced
this pull request
Jun 22, 2023
Signed-off-by: Yash Pimple <97302447+YashPimple@users.noreply.github.com> Signed-off-by: Yash Pimple <yashpimple22@gmail.com> Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> Co-authored-by: Meg McRoberts <DreidelLhasa@yahoo.com> Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relate #972
Fix #999
Resolved the markdown-lint issue
Signed-off-by: Yash Pimple yashpimple22@gmai.com