-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update KLT intro page #1495
Conversation
Signed-off-by: Pragati Saikia <92122197+pragatisaikia@users.noreply.github.com>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Just wondering why |
Also I'm not really sure that why do we need to shift to this from this for the comparison between Keptn V1 and the Keptn Lifecycle Toolkit. @StackScribe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes would fix the markdownlint
errors.
In re: @rakshitgondwal 's question about what videos to use to explain the difference between Keptn v1 and KLT... I'm not completely sure what to do about video references in the docs. They are a great way to add more information and many people do enjoy the videos and voice more than reading the text but we are also going to have to pay attention and keep updating the videos we use because they get outdated -- I'm sure we'll figure it out in time. I think the presentation Andi made in Pakistan is the most coherent presentation we have about the evolution from Keptn v1 to KLT and was thinking that maybe the meeting minutes were a little "rough". But we could certainly add Andi's Pakistan video and leave the meeting minutes video. Are you saying that you like the presentation from the community meeting better than the Pakistan video? Everyone has a vote here -- feel free to comment the issue saying that you think removing the link to the meeting minutes is stupid and say why! |
Yes! Actually, even me myself got to know about the difference between Keptn V1 and KLT from the meeting minutes video that's why I was more biased towards it. Just had one more question that the link for the KCD Pakistan video links to a specific timestamp of |
Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Signed-off-by: Pragati Saikia <92122197+pragatisaikia@users.noreply.github.com>
Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Signed-off-by: Pragati Saikia <92122197+pragatisaikia@users.noreply.github.com>
Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Signed-off-by: Pragati Saikia <92122197+pragatisaikia@users.noreply.github.com>
Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Signed-off-by: Pragati Saikia <92122197+pragatisaikia@users.noreply.github.com>
Signed-off-by: pragatisaikia <pragatisaikia2003@gmail.com>
I was just looking at this video which is a talk by Giovanni and Brad in KubeCon EU 2023, and I think we can consider this for the difference between V1 and KLT too. wdyt @StackScribe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed!
|
Signed-off-by: Pragati Saikia <92122197+pragatisaikia@users.noreply.github.com> Signed-off-by: pragatisaikia <pragatisaikia2003@gmail.com> Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Co-authored-by: Meg McRoberts <DreidelLhasa@yahoo.com>
Signed-off-by: Pragati Saikia <92122197+pragatisaikia@users.noreply.github.com> Signed-off-by: pragatisaikia <pragatisaikia2003@gmail.com> Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Co-authored-by: Meg McRoberts <DreidelLhasa@yahoo.com>
Fixes : #1467 and #1540
Files changed : link to the file