chore: remove decoder injector interface from webhook #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
RealAnna
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1563 +/- ##
==========================================
- Coverage 63.22% 63.12% -0.10%
==========================================
Files 142 142
Lines 10794 10800 +6
==========================================
- Hits 6824 6817 -7
- Misses 3715 3724 +9
- Partials 255 259 +4
... and 10 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
RealAnna
previously approved these changes
Jun 15, 2023
odubajDT
reviewed
Jun 15, 2023
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
odubajDT
approved these changes
Jun 15, 2023
RealAnna
approved these changes
Jun 15, 2023
|
Thank you @geoffrey1330 for your contribution! :) |
Merged
StackScribe
pushed a commit
to StackScribe/lifecycle-toolkit
that referenced
this pull request
Jun 19, 2023
StackScribe
pushed a commit
to StackScribe/lifecycle-toolkit
that referenced
this pull request
Jun 22, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1445 Removed Decoder Injector interface from webhook and explicitly initialized the decoder in the operator main
Signed-off-by: geoffrey1330 israelgeoffrey13@gmail.com