-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(lifecycle-operator): refactor event emitter unit tests #1867
Conversation
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1867 +/- ##
=======================================
Coverage 83.42% 83.42%
=======================================
Files 136 136
Lines 8348 8348
=======================================
Hits 6964 6964
Misses 1127 1127
Partials 257 257 see 2 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Note: I observed a flaky integration test during the checks for this PR, which is not related to the changes of this PR however. I created a separate issue to investigate the integration tests: #1870 |
This is a follow up to #1844 to get rid of the sleep in the unit tests, and use the auto generated mock event emitter instead of defining a new type in the unit tests