refactor(lifecycle-operator): refactor event emitter unit tests #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1867 +/- ##
=======================================
Coverage 83.42% 83.42%
=======================================
Files 136 136
Lines 8348 8348
=======================================
Hits 6964 6964
Misses 1127 1127
Partials 257 257 see 2 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Note: I observed a flaky integration test during the checks for this PR, which is not related to the changes of this PR however. I created a separate issue to investigate the integration tests: #1870 |
odubajDT
approved these changes
Aug 10, 2023
thisthat
approved these changes
Aug 11, 2023
RealAnna
approved these changes
Aug 11, 2023
This was referenced Aug 29, 2023
This was referenced Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #1844 to get rid of the sleep in the unit tests, and use the auto generated mock event emitter instead of defining a new type in the unit tests