Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update KeptnMetric to store multiple metrics in status #1900

Merged
merged 15 commits into from
Sep 21, 2023
Merged

feat: update KeptnMetric to store multiple metrics in status #1900

merged 15 commits into from
Sep 21, 2023

Conversation

rakshitgondwal
Copy link
Member

@rakshitgondwal rakshitgondwal commented Aug 17, 2023 •
edited

Fixes #2082

@rakshitgondwal
feat: add storedResult field for KeptnMetric
8aca000 
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
@netlify
Copy link

netlify bot commented Aug 17, 2023 •
edited

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 31c90c4
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/650aa506f464f40008b71485
😎 Deploy Preview https://deploy-preview-1900--keptn-lifecycle-toolkit.netlify.app/docs/crd-ref/metrics/v1alpha3
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 17, 2023 •
edited

Codecov Report

Merging #1900 (31c90c4) into main (2db2569) will decrease coverage by 0.05%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1900      +/-   ##
==========================================
- Coverage   84.37%   84.32%   -0.05%     
==========================================
  Files         150      150              
  Lines        9623     9623              
==========================================
- Hits         8119     8115       -4     
- Misses       1221     1224       +3     
- Partials      283      284       +1
Files Changed Coverage Δ
metrics-operator/api/v1alpha3/keptnmetric_types.go 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 65.91% <ø> (ø)
component-tests 58.06% <ø> (-0.28%) ⬇️
lifecycle-operator 84.94% <ø> (ø)
metrics-operator 87.15% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 12, 2023
@rakshitgondwal
modify status
d3fca13 
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
@rakshitgondwal rakshitgondwal changed the title feat: add storedResult field for KeptnMetric feat: update KeptnMetric to store multiple metrics in status Sep 12, 2023
rakshitgondwal and others added 3 commits September 13, 2023 17:00
@rakshitgondwal
add omitempty
eae2b02 
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
@rakshitgondwal
fix tests
9e1a9c1 
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
@rakshitgondwal
Merge branch 'main' into feat/storedResults-field-for-KeptnMetric
8cf0ef0 
Signed-off-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com>
@rakshitgondwal rakshitgondwal marked this pull request as ready for review September 14, 2023 11:11
@rakshitgondwal rakshitgondwal requested review from a team as code owners September 14, 2023 11:11
rakshitgondwal and others added 2 commits September 15, 2023 14:18
@rakshitgondwal
fix after review
d3e070a 
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
@rakshitgondwal
Merge branch 'main' into feat/storedResults-field-for-KeptnMetric
20d0c15
rakshitgondwal and others added 2 commits September 20, 2023 00:13
@rakshitgondwal
Merge branch 'main' into feat/storedResults-field-for-KeptnMetric
d195455
@rakshitgondwal
add omitempty tags
5aeda9c 
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
bacherfl and others added 2 commits September 20, 2023 07:40
@bacherfl
minor fixes, adapt helm templates
847da86 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@rakshitgondwal
Merge pull request #2 from bacherfl/feat/storedResults-field-for-Kept…
1a482b2 
…nMetric

minor fixes, adapt helm templates
@github-actions github-actions bot added the helm label Sep 20, 2023
bacherfl
bacherfl previously approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@bacherfl bacherfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the integration test run was likely a flaky one - i retriggered it just to be sure though

RealAnna
RealAnna previously approved these changes Sep 20, 2023
View reviewed changes
@rakshitgondwal
fix failing markdown test
31c90c4 
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bacherfl bacherfl merged commit 2252b2d into keptn:main Sep 21, 2023
41 checks passed
This was referenced Sep 21, 2023
Merged
Merged
@keptn-bot keptn-bot mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bacherfl bacherfl bacherfl approved these changes

@RealAnna RealAnna RealAnna approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation helm metrics-operator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the metrics API to support multiple metric values
3 participants
@rakshitgondwal @bacherfl @RealAnna