Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the metrics API to support multiple metric values #2082

Closed
Tracked by #1883
rakshitgondwal opened this issue Sep 12, 2023 · 0 comments · Fixed by #1900
Closed
Tracked by #1883

Update the metrics API to support multiple metric values #2082

rakshitgondwal opened this issue Sep 12, 2023 · 0 comments · Fixed by #1900
Assignees

Comments

@rakshitgondwal
Copy link
Member

rakshitgondwal commented Sep 12, 2023

Description

In order to have multiple metric values, we need to update our metrics API/ KeptnMetric as follows:

apiVersion: metrics.keptn.sh/v1alpha3
kind: KeptnMetric
metadata:
  name: podtato-head
spec:
  provider:
    name: "my-provider"
  query: "sum(kube_pod_container_resource_limits{resource='cpu'})"
  fetchIntervalSeconds: 5
  range:
    interval: "5m"
    step: "1m"
    aggregation: "p90"
    storedResults: 5
status:
  value: "1.0"
  rawValue: "{}"
  lastUpdated: ....
  errMsg: nil
  intervalResults:
  - value: 1
    range:
      from: ""
      to: ""
      aggregation: max
    lastUpdated: ...
    errMsg: nil
  - value: 1
    range:
      from: ""
      to: ""
      aggregation: max

DoD:

  • Add spec.range.storedResult field.
  • Modify the status, to have a slice of IntervalResult type structs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant