feat(metrics-operator): add basicauth to prometheus provider #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2154 +/- ##
==========================================
- Coverage 84.56% 75.09% -9.48%
==========================================
Files 153 68 -85
Lines 9881 4493 -5388
==========================================
- Hits 8356 3374 -4982
+ Misses 1237 954 -283
+ Partials 288 165 -123
... and 100 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
odubajDT
changed the title
RealAnna
commented
Sep 25, 2023
odubajDT
reviewed
Sep 25, 2023
metrics-operator/controllers/common/providers/prometheus/common.go
Outdated
Show resolved
Hide resolved
odubajDT
reviewed
Sep 25, 2023
metrics-operator/controllers/common/providers/prometheus/common.go
Outdated
Show resolved
Hide resolved
odubajDT
reviewed
Sep 25, 2023
metrics-operator/controllers/common/providers/prometheus/common_test.go
Outdated
Show resolved
Hide resolved
odubajDT
reviewed
Sep 25, 2023
odubajDT
reviewed
Sep 25, 2023
metrics-operator/controllers/common/providers/prometheus/prometheus.go
Outdated
Show resolved
Hide resolved
odubajDT
reviewed
Sep 26, 2023
odubajDT
reviewed
Sep 26, 2023
odubajDT
reviewed
Sep 26, 2023
metrics-operator/controllers/common/providers/prometheus/prometheus.go
Outdated
Show resolved
Hide resolved
odubajDT
reviewed
Sep 26, 2023
metrics-operator/controllers/common/providers/prometheus/prometheus.go
Outdated
Show resolved
Hide resolved
odubajDT
previously approved these changes
Sep 26, 2023
bacherfl
reviewed
Sep 26, 2023
metrics-operator/controllers/common/providers/prometheus/prometheus.go
Outdated
Show resolved
Hide resolved
bacherfl
reviewed
Sep 26, 2023
metrics-operator/controllers/common/providers/prometheus/common.go
Outdated
Show resolved
Hide resolved
bacherfl
reviewed
Sep 26, 2023
github-actions
bot
added
documentation
Signed-off-by: realanna <anna.reale@dynatrace.com>
… for specifying time frame (#2147) Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com> fix: link Signed-off-by: realanna <anna.reale@dynatrace.com> Update metrics-operator/controllers/common/providers/prometheus/prometheus.go Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com> Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com> Update metrics-operator/controllers/common/providers/prometheus/common.go Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com> Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com> fix: embed getter in the struct Signed-off-by: realanna <anna.reale@dynatrace.com> Update metrics-operator/controllers/common/providers/prometheus/prometheus.go Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com> Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com> fix: add unit test to make ondrej happy Signed-off-by: realanna <anna.reale@dynatrace.com> fix: removed skip lint Signed-off-by: realanna <anna.reale@dynatrace.com> fix: removed dd special func for secrets Signed-off-by: realanna <anna.reale@dynatrace.com> fix: useless test setup Signed-off-by: realanna <anna.reale@dynatrace.com> feat(metrics-operator): add unit test Signed-off-by: realanna <anna.reale@dynatrace.com> feat(metrics-operator): add unit test Signed-off-by: realanna <anna.reale@dynatrace.com> feat(metrics-operator): add integration test Signed-off-by: realanna <anna.reale@dynatrace.com> feat(metrics-operator): lint Signed-off-by: realanna <anna.reale@dynatrace.com> feat(metrics-operator): lint Signed-off-by: realanna <anna.reale@dynatrace.com> feat(metrics-operator): revert change to ddprovider Signed-off-by: realanna <anna.reale@dynatrace.com> feat(metrics-operator): fixed test Signed-off-by: realanna <anna.reale@dynatrace.com> feat(metrics-operator): use roundtripper from prometheus api Signed-off-by: realanna <anna.reale@dynatrace.com> feat(metrics-operator): add test of header Signed-off-by: realanna <anna.reale@dynatrace.com> feat(metrics-operator): add unit tests Signed-off-by: realanna <anna.reale@dynatrace.com> feat(metrics-operator): first iteration on prometheus auth Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
RealAnna
force-pushed
the
feat/2128/add_auth_in_prometheus_provider
branch
from
86bfa52
to
16954d3
Compare
github-actions
bot
removed
documentation
Signed-off-by: realanna <anna.reale@dynatrace.com>
RealAnna
commented
Sep 27, 2023
Signed-off-by: realanna <anna.reale@dynatrace.com>
odubajDT
reviewed
Sep 27, 2023
Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com> Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
odubajDT
reviewed
Sep 27, 2023
Signed-off-by: realanna <anna.reale@dynatrace.com>
odubajDT
approved these changes
Sep 27, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
bacherfl
approved these changes
Sep 28, 2023
This was referenced Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2128
this feature allows to send api calls to Prometheus using user and password