Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adapt code to use KeptnWorkloadVersion instead of KeptnWorkloadInstance #2255

Merged
merged 10 commits into from
Oct 13, 2023
Merged

feat: adapt code to use KeptnWorkloadVersion instead of KeptnWorkloadInstance #2255

merged 10 commits into from
Oct 13, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Oct 9, 2023

Fixes: #66

@github-actions github-actions bot added documentation Improvements or additions to documentation ops lifecycle-operator labels Oct 9, 2023
@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit f728b31
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6527dacc59b1a20008f00886
😎 Deploy Preview https://deploy-preview-2255--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #2255 (f728b31) into main (8dd3394) will increase coverage by 0.08%.
The diff coverage is 82.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2255      +/-   ##
==========================================
+ Coverage   85.57%   85.65%   +0.08%     
==========================================
  Files         159      159              
  Lines       10236    10227       -9     
==========================================
+ Hits         8759     8760       +1     
+ Misses       1202     1192      -10     
  Partials      275      275              
Files Coverage Δ
...-operator/apis/lifecycle/v1alpha3/common/phases.go 100.00% <ø> (ø)
...tor/apis/lifecycle/v1alpha3/keptnworkload_types.go 88.88% <ø> (-5.06%) ⬇️
...s/lifecycle/v1alpha4/keptnworkloadversion_types.go 99.06% <100.00%> (+3.56%) ⬆️
...rator/controllers/common/schedulinggateshandler.go 81.03% <100.00%> (ø)
...ontrollers/lifecycle/keptnappversion/controller.go 82.30% <ø> (ø)
...eptnworkloadversion/reconcile_prepostdeployment.go 81.81% <100.00%> (ø)
...eptnworkloadversion/reconcile_prepostevaluation.go 90.90% <100.00%> (ø)
...ecycle/keptnappversion/reconcile_workloadsstate.go 93.75% <90.90%> (ø)
.../keptnworkloadversion/reconcile_deploymentstate.go 72.22% <87.50%> (ø)
...perator/controllers/common/telemetry/otel_utils.go 73.83% <0.00%> (ø)
... and 3 more

... and 2 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.19% <ø> (ø)
component-tests 59.18% <73.28%> (+1.07%) ⬆️
lifecycle-operator 85.45% <57.86%> (-1.07%) ⬇️
metrics-operator 87.55% <ø> (ø)
scheduler 32.12% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT changed the title Feat/66/workloadversion feat: adapt code to use KeptnWorkloadVersion instead of KeptnWorkloadInstance Oct 10, 2023
@odubajDT odubajDT marked this pull request as ready for review October 11, 2023 06:58
@odubajDT odubajDT requested review from a team as code owners October 11, 2023 06:58
@RealAnna
Copy link
Contributor

@odubajDT
Copy link
Contributor Author

should we make a refactoring issue for this guy? https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&pullRequest=2255&id=keptn_lifecycle-toolkit&open=AYsU8dz3bEml1DOqvng7

yep I guess we should

@RealAnna
Copy link
Contributor

bacherfl
bacherfl previously approved these changes Oct 12, 2023
…ead of KeptnWorkloadInstance

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 39 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great 👍

@odubajDT odubajDT merged commit c06fae1 into keptn:main Oct 13, 2023
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lifecycle-operator ops scheduler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename WorkloadInstance to WorkloadVersion
4 participants