-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adapt code to use KeptnWorkloadVersion instead of KeptnWorkloadInstance #2255
Conversation
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2255 +/- ##
==========================================
+ Coverage 85.57% 85.65% +0.08%
==========================================
Files 159 159
Lines 10236 10227 -9
==========================================
+ Hits 8759 8760 +1
+ Misses 1202 1192 -10
Partials 275 275
... and 2 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
should we make a refactoring issue for this guy? https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&pullRequest=2255&id=keptn_lifecycle-toolkit&open=AYsU8dz3bEml1DOqvng7 |
yep I guess we should |
|
lifecycle-operator/apis/lifecycle/v1alpha4/keptnworkloadversion_types.go
Show resolved
Hide resolved
lifecycle-operator/controllers/lifecycle/keptnworkloadversion/reconcile_prepostevaluation.go
Show resolved
Hide resolved
…ead of KeptnWorkloadInstance Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great 👍
Fixes: #66