Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove performance-test workflow and relative makefile entry #2706

Merged
merged 3 commits into from
Jan 12, 2024
Merged

chore: remove performance-test workflow and relative makefile entry #2706

merged 3 commits into from
Jan 12, 2024

Conversation

ShivangShandilya
Copy link
Contributor

This PR fixes: #2328

This PR simply works on removing the performance-test workflow as we already have the load test workflow that evaluates our performances in an E2E fashion and also removes its subsequent makefile entry.

@ShivangShandilya ShivangShandilya requested a review from a team as a code owner December 19, 2023 21:08
mowies
mowies previously requested changes Dec 20, 2023
View reviewed changes
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also remove any occurrences of this workflow being called in other workflows. I see it being called in CI.yml

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 23, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ShivangShandilya
Copy link
Contributor Author

please also remove any occurrences of this workflow being called in other workflows. I see it being called in CI.yml

Made necessary changes and also did a re-check for occurrence of this workflow in any other workflows but turns out it was only present in CI.yml as you stated.

@ShivangShandilya
Copy link
Contributor Author

Looks like spell-check is failing for docs-new/overrides/main.html file

@codecov Codecov
Copy link

codecov bot commented Jan 5, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (217542e) 85.70% compared to head (1f20deb) 85.71%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2706   +/-   ##
=======================================
  Coverage   85.70%   85.71%           
=======================================
  Files         160      160           
  Lines       10139    10139           
=======================================
+ Hits         8690     8691    +1     
  Misses       1169     1169           
+ Partials      280      279    -1

see 3 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.42% <ø> (ø)
component-tests 57.33% <ø> (+0.62%) ⬆️
lifecycle-operator 84.72% <ø> (ø)
metrics-operator 87.43% <ø> (ø)
scheduler 36.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@rakshitgondwal
Copy link
Member

Hi @ShivangShandilya, please rebase the branch. The spell check error has been fixed in #2750

@rakshitgondwal
Copy link
Member

I believe we should also modify the make performance-test occurrences in the docs.

@odubajDT
Copy link
Contributor

Hi @ShivangShandilya any progress here ?

ShivangShandilya and others added 3 commits January 12, 2024 13:51
@ShivangShandilya @odubajDT
remove performance-test
d916aa2 
Signed-off-by: ShivangShandilya <shivangshandilya83@gmail.com>
@ShivangShandilya @odubajDT
Update CI.yaml
fd56f90 
Signed-off-by: Shivang Shandilya <101946115+ShivangShandilya@users.noreply.github.com>
@odubajDT
remove performance-test infor from docs
1f20deb 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 12, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

3.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@odubajDT
Copy link
Contributor

@ShivangShandilya thank you for contribution!

@odubajDT odubajDT merged commit 8599276 into keptn:main Jan 12, 2024
32 of 33 checks passed
@keptn-bot keptn-bot mentioned this pull request Jan 12, 2024
Merged
@keptn-bot keptn-bot mentioned this pull request Jan 23, 2024
Merged
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
@ShivangShandilya @odubajDT @Vickysomtee
chore: remove performance-test workflow and relative makefile entry (k…
d04dd2a 
…eptn#2706)

Signed-off-by: ShivangShandilya <shivangshandilya83@gmail.com>
Signed-off-by: Shivang Shandilya <101946115+ShivangShandilya@users.noreply.github.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Co-authored-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: vickysomtee <vickysomtee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RealAnna RealAnna RealAnna approved these changes

@odubajDT odubajDT odubajDT approved these changes

@mowies mowies Awaiting requested review from mowies

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation lifecycle-operator ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: Remove performance test pipeline
5 participants
@ShivangShandilya @rakshitgondwal @odubajDT @mowies @RealAnna