Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Thanos metrics provider in Keptn Metrics Operator #2900

Closed
4 tasks
Tracked by #2850
odubajDT opened this issue Jan 29, 2024 · 6 comments · Fixed by #3358
Closed
4 tasks
Tracked by #2850

Support Thanos metrics provider in Keptn Metrics Operator #2900

odubajDT opened this issue Jan 29, 2024 · 6 comments · Fixed by #3358
Assignees
Labels
documentation Improvements or additions to documentation metrics-operator tests

Comments

@odubajDT
Copy link
Contributor

odubajDT commented Jan 29, 2024

Goal

Support Thanos metrics provider as Keptn Metrics Provider.

Details

Thanos implements the Prometheus HTTP API to query data via PromQL. Therefore it is possible to use the current implementation of Prometheus provider and introduce an integration with Thanos.

DoD

  • use the already implemented Prometheus provider and adapt the provider.go to support Thanos
  • unit tests
  • integration tests
  • document new provider usage
@odubajDT odubajDT added metrics-operator tests documentation Improvements or additions to documentation status: ready-for-refinement Issue is relevant for the next backlog refinment labels Jan 29, 2024
@sudiptob2
Copy link
Member

I am interested in this ticket

@odubajDT
Copy link
Contributor Author

Thanks for interest! We need to refine it first, but afterwards it can be assigned to you directly :)

@mowies mowies added this to the 0.12 milestone Jan 30, 2024
@mowies mowies added status: draft and removed status: ready-for-refinement Issue is relevant for the next backlog refinment labels Jan 31, 2024
@rakshitgondwal
Copy link
Member

We already have a draft PR open to integrate thaons as a provider #1267

@shayyxi
Copy link

shayyxi commented Feb 2, 2024

I am continuing the work on the PR which would implement this.

@mowies mowies removed this from the 0.12 milestone Feb 20, 2024
@mowies
Copy link
Member

mowies commented Feb 21, 2024

docs on how to create a new metrics provider: https://keptn.sh/latest/docs/contribute/software/add-new-metric-provider/

@odubajDT
Copy link
Contributor Author

Hi @shayyxi due to time pressure for the upcoming stable release, we decided to unassign the issue from you to make it available for other contributors. Please feel free to grab another issue and thank you for your effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation metrics-operator tests
Projects
Archived in project
5 participants