Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Cortex metrics provider in Keptn Metrics Operator #2903

Closed
3 tasks done
Tracked by #2850
odubajDT opened this issue Jan 29, 2024 · 6 comments · Fixed by #3361
Closed
3 tasks done
Tracked by #2850

Support Cortex metrics provider in Keptn Metrics Operator #2903

odubajDT opened this issue Jan 29, 2024 · 6 comments · Fixed by #3361
Assignees
Labels
documentation Improvements or additions to documentation metrics-operator tests

Comments

@odubajDT
Copy link
Contributor

odubajDT commented Jan 29, 2024

Goal

Support Cortex metrics provider as Keptn Metrics Provider.

Details

Cortex implements the Prometheus HTTP API to query data via PromQL. Therefore it is possible to use the current implementation of Prometheus provider and introduce an integration with Cortex.

DoD

  • use the already implemented Prometheus provider and adapt the provider.go to support Cortex
  • unit tests
  • document new provider usage
@odubajDT odubajDT added documentation Improvements or additions to documentation status: ready-for-refinement Issue is relevant for the next backlog refinment metrics-operator tests labels Jan 29, 2024
@mowies mowies removed the status: ready-for-refinement Issue is relevant for the next backlog refinment label Jan 31, 2024
@geoffrey1330
Copy link
Member

Hi @odubajDT could you please assign this issue to me
cc @mowies

@mowies
Copy link
Member

mowies commented Jan 31, 2024

sure! but since the whole integration epic (the parent issue for this one) is planned for 0.12, it could be that we won't merge the PR anytime soon, just so you're aware :)

@mowies mowies added this to the 0.12 milestone Jan 31, 2024
@geoffrey1330
Copy link
Member

sure! but since the whole integration epic (the parent issue for this one) is planned for 0.12, it could be that we won't merge the PR anytime soon, just so you're aware :)

Alright

@mowies mowies removed this from the 0.12 milestone Feb 20, 2024
@mowies
Copy link
Member

mowies commented Feb 21, 2024

docs on how to create a new metrics provider: https://keptn.sh/latest/docs/contribute/software/add-new-metric-provider/

@odubajDT
Copy link
Contributor Author

Hi @geoffrey1330, since you are actively working on #3037 I am going to unassign you from this issue to make it available for other contributors. Please feel free to request it again when you are finished with #3037!

@geoffrey1330
Copy link
Member

Hi @geoffrey1330, since you are actively working on #3037 I am going to unassign you from this issue to make it available for other contributors. Please feel free to request it again when you are finished with #3037!

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation metrics-operator tests
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants