Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move kuttl tests in sub folder #2914

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

eddycharly
Copy link
Contributor

Description

Move kuttl tests in sub folder (test/kuttl/...)

@eddycharly eddycharly marked this pull request as ready for review January 31, 2024 09:02
@eddycharly eddycharly requested review from a team as code owners January 31, 2024 09:02
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (90afcc7) 85.78% compared to head (f29c28e) 85.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2914      +/-   ##
==========================================
+ Coverage   85.78%   85.82%   +0.03%     
==========================================
  Files         161      161              
  Lines       10252    10252              
==========================================
+ Hits         8795     8799       +4     
+ Misses       1173     1170       -3     
+ Partials      284      283       -1     

see 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.42% <ø> (ø)
component-tests 56.09% <ø> (+0.26%) ⬆️
lifecycle-operator 84.88% <ø> (ø)
metrics-operator 87.63% <ø> (ø)
scheduler 36.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@RealAnna
Copy link
Contributor

we can ignore the new test path here

docs/docs/guides/slo.md Outdated Show resolved Hide resolved
@eddycharly
Copy link
Contributor Author

we can ignore the new test path here

i need to find the right sonar analyser/syntax 🤔

@eddycharly eddycharly force-pushed the move-kuttl-tests branch 2 times, most recently from f035426 to 711ca46 Compare January 31, 2024 10:08
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Copy link

sonarcloud bot commented Jan 31, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RealAnna RealAnna merged commit c2cb744 into keptn:main Jan 31, 2024
34 checks passed
@eddycharly eddycharly deleted the move-kuttl-tests branch January 31, 2024 10:37
bacherfl pushed a commit to bacherfl/lifecycle-controller that referenced this pull request Feb 5, 2024
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: vickysomtee <vickysomtee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants