Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lifecycle-operator): add namespace to deploymentduration metrics #3292

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

pimmerks
Copy link
Contributor

@pimmerks pimmerks commented Mar 19, 2024

Description

This PR adds namespace attributes to both keptn_app_deploymentduration and keptn_deployment_deploymentduration metrics.

All other DORA specific metrics include either the keptn_deployment_app_namespace or the keptn_deployment_workload_namespace, except for the _deploymentduration. This PR fixes that.

This is useful for our usecase where we want to filter deploymentduration per namespace instead of per app.

How to test

Unit tests have been updated, manual verification was done to check if these namespace attributes are present on the exported metrics at localhost:2222/metrics.

Checklist

  • My PR fulfills the Definition of Done of the corresponding issue and not more (or parts if the issue is separated
    into multiple PRs)
  • I used descriptive commit messages to help reviewers understand my thought process
  • I signed off all my commits according to the Developer Certificate of Origin (DCO)
    see Contribution Guide
  • My PR title is formatted according to the semantic PR conventions described in
    the Contribution Guide
  • My code follows the style guidelines of this project (golangci-lint passes, YAMLLint passes)
  • I regenerated the auto-generated docs for Helm and the CRD documentation (if applicable)
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation (if needed)
  • My changes result in all-green PR checks (first-time contributors need to ask a maintainer to approve their test runs)
  • New and existing unit and integration tests pass locally with my changes

Signed-off-by: Pim Merks <pimmerks@users.noreply.github.com>
Copy link

sonarcloud bot commented Mar 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@pimmerks pimmerks marked this pull request as ready for review March 19, 2024 11:10
@pimmerks pimmerks requested a review from a team as a code owner March 19, 2024 11:10
Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@odubajDT odubajDT merged commit 0735e31 into keptn:main Mar 19, 2024
43 checks passed
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
…cs (keptn#3292)

Signed-off-by: Pim Merks <pimmerks@users.noreply.github.com>
Signed-off-by: vickysomtee <vickysomtee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants