feat(lifecycle-operator): add namespace to deploymentduration
metrics
#3292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds namespace attributes to both
keptn_app_deploymentduration
andkeptn_deployment_deploymentduration
metrics.All other DORA specific metrics include either the
keptn_deployment_app_namespace
or thekeptn_deployment_workload_namespace
, except for the_deploymentduration
. This PR fixes that.This is useful for our usecase where we want to filter deploymentduration per namespace instead of per app.
How to test
Unit tests have been updated, manual verification was done to check if these namespace attributes are present on the exported metrics at
localhost:2222/metrics
.Checklist
into multiple PRs)
see Contribution Guide
the Contribution Guide