Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lifecycle-operator): move API HUB version to v1 #3350

Merged
merged 5 commits into from
Mar 26, 2024

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Mar 26, 2024

Fixes: #3235

Changes

  • move HUB version to v1
  • adapted conversion webhooks
  • remove usage of v1beta1 version outside of /apis/lifecycle folder
  • align all imports of lifecycle API for easier future HUB moving
  • adapt integration tests

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@github-actions github-actions bot added documentation Improvements or additions to documentation ops lifecycle-operator labels Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 96.64570% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 88.04%. Comparing base (15a8ae3) to head (f34234f).

❗ Current head f34234f differs from pull request most recent head 2d62d95. Consider uploading reports for the commit 2d62d95 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3350   +/-   ##
=======================================
  Coverage   88.04%   88.04%           
=======================================
  Files         176      176           
  Lines        9604     9604           
=======================================
  Hits         8456     8456           
  Misses        854      854           
  Partials      294      294           
Files Coverage Δ
...ecycle-operator/apis/lifecycle/v1/common/common.go 100.00% <ø> (ø)
...cycle-operator/apis/lifecycle/v1/keptnapp_types.go 92.30% <ø> (ø)
...cle-operator/apis/lifecycle/v1/keptnapp_webhook.go 0.00% <ø> (ø)
...perator/apis/lifecycle/v1/keptnappcontext_types.go 100.00% <ø> (ø)
...apis/lifecycle/v1/keptnappcreationrequest_types.go 77.77% <ø> (ø)
...perator/apis/lifecycle/v1/keptnappversion_types.go 98.20% <ø> (ø)
...rator/apis/lifecycle/v1/keptnappversion_webhook.go 0.00% <ø> (ø)
...perator/apis/lifecycle/v1/keptnevaluation_types.go 96.82% <ø> (ø)
...is/lifecycle/v1/keptnevaluationdefinition_types.go 100.00% <ø> (ø)
...ycle-operator/apis/lifecycle/v1/keptntask_types.go 97.29% <ø> (ø)
... and 64 more
Flag Coverage Δ
certificate-operator 69.23% <ø> (ø)
component-tests 58.04% <80.00%> (ø)
lifecycle-operator 88.08% <93.02%> (ø)
metrics-operator 88.32% <ø> (ø)
scheduler 34.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@odubajDT odubajDT marked this pull request as ready for review March 26, 2024 11:51
@odubajDT odubajDT requested review from a team as code owners March 26, 2024 11:51
@odubajDT odubajDT merged commit eed393b into keptn:main Mar 26, 2024
46 checks passed
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: vickysomtee <vickysomtee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lifecycle-operator ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change hub version to v1, adapt conversion webhooks, use in controllers
3 participants