Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lifecycle-operator): clean up unused API logic #3351

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

odubajDT
Copy link
Contributor

Depends on: #3350

@github-actions github-actions bot added documentation Improvements or additions to documentation ops lifecycle-operator labels Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.29%. Comparing base (25d5c06) to head (17d821b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3351      +/-   ##
==========================================
- Coverage   88.04%   85.29%   -2.76%     
==========================================
  Files         176      167       -9     
  Lines        9604     7412    -2192     
==========================================
- Hits         8456     6322    -2134     
+ Misses        854      801      -53     
+ Partials      294      289       -5     
Files Coverage Δ
...ecycle-operator/apis/lifecycle/v1/common/phases.go 100.00% <ø> (ø)
...cycle-operator/apis/lifecycle/v1/keptnapp_types.go 92.30% <ø> (ø)
...operator/apis/lifecycle/v1alpha1/keptnapp_types.go 100.00% <ø> (+9.09%) ⬆️
...r/apis/lifecycle/v1alpha1/keptnappversion_types.go 28.57% <ø> (-68.92%) ⬇️
...r/apis/lifecycle/v1alpha1/keptnevaluation_types.go 100.00% <ø> (+3.63%) ⬆️
...ecycle/v1alpha1/keptnevaluationdefinition_types.go 100.00% <ø> (ø)
...ifecycle/v1alpha1/keptnevaluationprovider_types.go 100.00% <ø> (ø)
...perator/apis/lifecycle/v1alpha1/keptntask_types.go 100.00% <ø> (+3.33%) ⬆️
...is/lifecycle/v1alpha1/keptntaskdefinition_types.go 100.00% <ø> (ø)
...tor/apis/lifecycle/v1alpha1/keptnworkload_types.go 100.00% <ø> (+8.69%) ⬆️
... and 28 more

... and 2 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 69.23% <ø> (ø)
component-tests 57.79% <ø> (-0.25%) ⬇️
lifecycle-operator 83.46% <ø> (-4.62%) ⬇️
metrics-operator 88.32% <ø> (ø)
scheduler 34.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT marked this pull request as ready for review March 26, 2024 14:17
@odubajDT odubajDT requested review from a team as code owners March 26, 2024 14:17
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@odubajDT odubajDT merged commit 016dc07 into keptn:main Apr 2, 2024
46 of 47 checks passed
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: vickysomtee <vickysomtee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lifecycle-operator ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants