Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(operator): Do not proceed with WLI if no AppVersion containing it is available #377

Merged
merged 5 commits into from
Nov 14, 2022

Conversation

bacherfl
Copy link
Member

Closes #372

Signed-off-by: Florian Bacher florian.bacher@dynatrace.com

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #377 (2aee04e) into main (4d16a77) will increase coverage by 1.68%.
The diff coverage is 54.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
+ Coverage   20.89%   22.57%   +1.68%     
==========================================
  Files          15       15              
  Lines        1096     1103       +7     
==========================================
+ Hits          229      249      +20     
+ Misses        852      839      -13     
  Partials       15       15              
Impacted Files Coverage Δ
...or/controllers/keptnworkloadinstance/controller.go 10.25% <54.54%> (+10.25%) ⬆️
Flag Coverage Δ
keptn-lifecycle-operator 27.09% <54.54%> (+2.06%) ⬆️
scheduler 4.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bacherfl bacherfl changed the title fix(operator): Do no proceed with WLI of no AppVersion containing it is available fix(operator): Do not proceed with WLI of no AppVersion containing it is available Nov 11, 2022
@bacherfl bacherfl marked this pull request as ready for review November 11, 2022 07:47
thschue
thschue previously approved these changes Nov 11, 2022
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bacherfl bacherfl changed the title fix(operator): Do not proceed with WLI of no AppVersion containing it is available fix(operator): Do not proceed with WLI if no AppVersion containing it is available Nov 14, 2022
…is available

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bacherfl bacherfl merged commit cf74540 into keptn:main Nov 14, 2022
@bacherfl bacherfl deleted the fix/wli-app-version-check branch November 14, 2022 11:24
@keptn-bot keptn-bot mentioned this pull request Nov 14, 2022
thschue pushed a commit to thschue/lifecycle-controller that referenced this pull request Nov 15, 2022
… is available (keptn#377)

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workloads are deployed although not part of an application
3 participants