Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(operator): evaluation controller uses KeptnMetric as SLI provider #661

Merged
merged 9 commits into from
Jan 20, 2023

Conversation

odubajDT
Copy link
Contributor

Signed-off-by: odubajDT ondrej.dubaj@dynatrace.com

Fixes: #609

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #661 (a72ba0e) into main (ed5e200) will increase coverage by 1.52%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #661      +/-   ##
==========================================
+ Coverage   54.87%   56.39%   +1.52%     
==========================================
  Files          79       82       +3     
  Lines        6584     6683      +99     
==========================================
+ Hits         3613     3769     +156     
+ Misses       2819     2755      -64     
- Partials      152      159       +7     
Impacted Files Coverage Δ
operator/controllers/common/providers/dynatrace.go 82.53% <ø> (ø)
...perator/controllers/common/providers/prometheus.go 85.36% <ø> (ø)
...perator/apis/metrics/v1alpha1/keptnmetric_types.go 100.00% <100.00%> (ø)
...erator/controllers/common/providers/keptnmetric.go 100.00% <100.00%> (ø)
operator/controllers/common/providers/provider.go 100.00% <100.00%> (ø)
...ontrollers/lifecycle/keptnevaluation/controller.go 81.28% <100.00%> (+81.28%) ⬆️
...ptnworkloadinstance/reconcile_prepostdeployment.go 81.81% <0.00%> (-9.10%) ⬇️
...lers/lifecycle/keptnworkloadinstance/controller.go 76.38% <0.00%> (-1.86%) ⬇️
...tor/apis/metrics/v1alpha1/zz_generated.deepcopy.go 0.00% <0.00%> (ø)
... and 2 more
Flag Coverage Δ
component-tests 54.01% <91.30%> (+0.19%) ⬆️
keptn-cert-manager 67.56% <ø> (ø)
keptn-lifecycle-operator 52.01% <100.00%> (-0.27%) ⬇️
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT odubajDT marked this pull request as ready for review January 19, 2023 14:14
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
thisthat
thisthat previously approved these changes Jan 20, 2023
Signed-off-by: realanna <anna.reale@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odubajDT odubajDT merged commit da8fcee into keptn:main Jan 20, 2023
@keptn-bot keptn-bot mentioned this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keptn evaluations consume KeptnMetrics
4 participants