New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`postDeploymentTasks` task is missing in the sample-application example #787

Closed

sudiptob2 opened this issue Feb 7, 2023 · 0 comments · Fixed by #788

Member

sudiptob2 commented Feb 7, 2023 •

edited

Loading

The example sample-application talks about slack notification as a post-deployment task. However the app manifest app.yaml is missing a postDeploymentTask declaration.
As a result, users don't get slack notifications after the deployment is completed.

DoD

Add postDeploymentTasks in the base/app.yaml

The text was updated successfully, but these errors were encountered:

sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue


          fix: added slack notification post deployment task (keptn#787)

9a9dbb5

Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>

sudiptob2 mentioned this issue

docs: added documentation to enable Slack notification post deployment task (#787) #788

Merged

3 tasks

sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue


          fix: removed postDeploymentTask from the main as not everyone has sla…

eac45a6

…ck configuration (keptn#787)

Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>

sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue


          docs: improved documentation on enabling post deployment task(keptn#787)

405ce1e

Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>

sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue


          docs: added implement-slack-notification task in the docs (keptn#787)

17ac4ac

Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>

sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue


          docs: updated create slack secret instruction (keptn#787)

Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>

sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue


          docs: weight adjusted to to put slack-notification after write task a…

c27d10d

…nd befor evaluate(keptn#787)

Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>

sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue


          docs: updated sample-app readme wording.(keptn#787)

e17f58a

Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>

sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue


          fix: added slack notification post deployment task (keptn#787)

23a4ba6

Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>

sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue


          fix: removed postDeploymentTask from the main as not everyone has sla…

3aed996

…ck configuration (keptn#787)

Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>

sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue


          docs: improved documentation on enabling post deployment task(keptn#787)

ef6652a

Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>

sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue


          docs: added implement-slack-notification task in the docs (keptn#787)

98f4fcb

Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>

sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue


          docs: updated create slack secret instruction (keptn#787)

c59a63b

Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>

sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue


          docs: weight adjusted to to put slack-notification after write task a…

0b26a48

…nd befor evaluate(keptn#787)

Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>

sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue


          docs: updated sample-app readme wording.(keptn#787)

3e93310

Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>

sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue


          docs: removed hyperlink from the docs.(keptn#787)

95035f0

Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>

thisthat closed this as completed in #788

thisthat pushed a commit that referenced this issue


          docs: added documentation to enable Slack notification post deploymen…

28a7319

…t task (#787) (#788)

Fixes #787

keptn-bot mentioned this issue

chore: release 0.6.0 #592

Merged

sudiptob2 mentioned this issue

REQUEST: Membership Member for @sudiptob2 keptn/community#337

Closed

7 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment