-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(operator): fix calculation of deployment interval metrics #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #822 +/- ##
==========================================
+ Coverage 57.75% 58.55% +0.80%
==========================================
Files 91 97 +6
Lines 7243 7552 +309
==========================================
+ Hits 4183 4422 +239
- Misses 2891 2938 +47
- Partials 169 192 +23
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Kudos, SonarCloud Quality Gate passed!
|
bacherfl
commented
Feb 13, 2023
odubajDT
approved these changes
Feb 13, 2023
thisthat
approved these changes
Feb 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #807
This PR fixes the calculation of the deployment interval metrics.
When calculating these metrics for AppVersions, which support multiple revisions for the same version since the last release, the earliest revision of a KeptnAppVersion's predecessor is being used as a reference.
Signed-off-by: Florian Bacher florian.bacher@dynatrace.com