Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move conversion webhooks to hub version API (v1alpha3) #992

Merged
merged 1 commit into from
Mar 8, 2023
Merged

fix: move conversion webhooks to hub version API (v1alpha3) #992

merged 1 commit into from
Mar 8, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Mar 7, 2023

No description provided.

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@netlify
Copy link

netlify bot commented Mar 7, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 03f5cc5
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/640744c59e32ed000875febc
😎 Deploy Preview https://deploy-preview-992--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Mar 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.9% 2.9% Duplication

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #992 (03f5cc5) into main (59ee362) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #992      +/-   ##
==========================================
- Coverage   57.81%   57.71%   -0.10%     
==========================================
  Files         122      126       +4     
  Lines       10095    10111      +16     
==========================================
  Hits         5836     5836              
- Misses       4051     4067      +16     
  Partials      208      208              
Impacted Files Coverage Δ
...erator/apis/lifecycle/v1alpha3/keptnapp_webhook.go 0.00% <ø> (ø)
...apis/lifecycle/v1alpha3/keptnappversion_webhook.go 0.00% <ø> (ø)
...ecycle/v1alpha3/keptnevaluationprovider_webhook.go 0.00% <0.00%> (ø)
...ifecycle/v1alpha3/keptnworkloadinstance_webhook.go 0.00% <ø> (ø)
Flag Coverage Δ
certificate-operator 64.15% <ø> (ø)
component-tests 53.12% <ø> (+0.05%) ⬆️
lifecycle-operator 53.63% <0.00%> (ø)
metrics-operator 62.98% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT marked this pull request as ready for review March 7, 2023 14:18
@odubajDT odubajDT merged commit b2bb268 into keptn:main Mar 8, 2023
@keptn-bot keptn-bot mentioned this pull request Mar 8, 2023
@keptn-bot keptn-bot mentioned this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants