Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(operator): additional parameters for KeptnTask to support retry logic #1084

Merged
merged 1 commit into from
Mar 22, 2023
Merged

feat(operator): additional parameters for KeptnTask to support retry logic #1084

merged 1 commit into from
Mar 22, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Mar 22, 2023

Part of: #64 #667

This PR

  • adds new fields Retry and Timeout to KeptnTaskDefinition and KeptnTask to support retry logic for KeptnTask
  • refactoring of the code to make the implementation of the controller logic more straight forward

@netlify
Copy link

netlify bot commented Mar 22, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 2cd7624
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/641ac613ec3ba30008d6cdc7
😎 Deploy Preview https://deploy-preview-1084--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

…logic

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #1084 (1c83b23) into main (8e93f88) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1084      +/-   ##
==========================================
+ Coverage   58.88%   58.91%   +0.03%     
==========================================
  Files         126      126              
  Lines       10003    10007       +4     
==========================================
+ Hits         5890     5896       +6     
+ Misses       3894     3893       -1     
+ Partials      219      218       -1     
Impacted Files Coverage Δ
...perator/apis/lifecycle/v1alpha3/keptntask_types.go 97.46% <ø> (ø)
...is/lifecycle/v1alpha3/keptntaskdefinition_types.go 100.00% <ø> (ø)
...r/apis/lifecycle/v1alpha3/zz_generated.deepcopy.go 0.00% <ø> (ø)
operator/controllers/common/helperfunctions.go 100.00% <ø> (ø)
...r/apis/lifecycle/v1alpha3/keptnappversion_types.go 97.61% <100.00%> (+0.02%) ⬆️
.../lifecycle/v1alpha3/keptnworkloadinstance_types.go 95.37% <100.00%> (+0.04%) ⬆️
operator/controllers/common/evaluationhandler.go 77.53% <100.00%> (ø)
operator/controllers/common/taskhandler.go 76.51% <100.00%> (ø)
...ator/controllers/lifecycle/interfaces/phaseitem.go 94.82% <100.00%> (ø)
...cle/keptnappversion/reconcile_prepostdeployment.go 81.81% <100.00%> (ø)
... and 3 more

... and 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 64.15% <ø> (ø)
component-tests 61.05% <100.00%> (+1.22%) ⬆️
lifecycle-operator 78.40% <93.75%> (+0.01%) ⬆️
metrics-operator 77.35% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT marked this pull request as ready for review March 22, 2023 09:46
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@odubajDT odubajDT merged commit eed5568 into keptn:main Mar 22, 2023
@keptn-bot keptn-bot mentioned this pull request Mar 22, 2023
aepfli pushed a commit to aepfli/lifecycle-toolkit that referenced this pull request Mar 30, 2023
…logic (keptn#1084)

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants