Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: create "observability" getting started guide #1376

Merged
merged 43 commits into from
May 22, 2023
Merged

docs: create "observability" getting started guide #1376

merged 43 commits into from
May 22, 2023

Conversation

StackScribe
Copy link
Contributor

@StackScribe StackScribe commented May 5, 2023 •
edited by thisthat
Loading

This implements #1301
This replaces #1323

It transcribes what is in Andi's video and starts to flip it into a how-to guide.

@StackScribe
docs: create metrics getting started guide
80f05f9 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe
markdownlint-fix
86d4b2f 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe
Copy in install
53b10d3 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe
docs: create observability getting started guide
bb4a978 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe
markdownlint-fix
723d7ef 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe StackScribe added the documentation Improvements or additions to documentation label May 5, 2023
@StackScribe StackScribe requested a review from a team as a code owner May 5, 2023 06:02
@StackScribe StackScribe self-assigned this May 5, 2023
@StackScribe StackScribe requested a review from a team as a code owner May 5, 2023 06:02
@netlify
Copy link

netlify bot commented May 5, 2023 •
edited
Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 31908a1
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/646b18de10c73b0008ac1735
😎 Deploy Preview https://deploy-preview-1376--keptn-lifecycle-toolkit.netlify.app/docs/getting-started/observability
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@StackScribe StackScribe mentioned this pull request May 5, 2023
Closed
StackScribe and others added 13 commits May 5, 2023 00:50
@StackScribe
remove xref to implementing/metrics until it is merged
bd38922 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe
Merge branch 'main' into 0504-observe-gs
278b381
@StackScribe
Merge branch 'main' into 0504-observe-gs
bcc1d44
@StackScribe
delete extra install line
76895f9 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe
Merge branch '0504-observe-gs' of github.com:StackScribe/lifecycle-to…
0b9edef 
…olkit into 0504-observe-gs

Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com
@aepfli
fix markdownlink issues and adding exception for github, as it will f…
a7efb2d 
…ail on automation tools

Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
@StackScribe
Merge branch 'main' into 0504-observe-gs
4199e3a
@StackScribe
Using this exercise
866653d 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe
markdownlint-fix
1e004e0 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe
Add text, structure
a6a7b81 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe
ref other sections for enable, annotate
161d1de 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe
clean up & refinement
4fab348 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe
Delete _index.md
3a3c932 
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe
Copy link
Contributor Author

I don't know why the metrics gs guide got sucked into this PR or why the observability text is not available in netlify. I deleted the metrics file from the PR but it is still giving me merge conflicts. I may need to create a new PR with this content but I will let this PR sit here for review today.

thisthat
thisthat reviewed May 16, 2023
View reviewed changes
docs/content/en/docs/getting-started/observability/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/getting-started/observability/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/getting-started/observability/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/getting-started/observability/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/getting-started/observability/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/getting-started/observability/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/getting-started/observability/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/getting-started/observability/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/getting-started/observability/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/getting-started/observability/_index.md Outdated Show resolved Hide resolved
StackScribe and others added 3 commits May 16, 2023 12:48
@StackScribe @thisthat
Update docs/content/en/docs/getting-started/observability/_index.md
c16445e 
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: Meg McRoberts <mmcroberts@cloudbees.com>
@StackScribe @thisthat
Update docs/content/en/docs/getting-started/observability/_index.md
da01916 
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: Meg McRoberts <mmcroberts@cloudbees.com>
@StackScribe @thisthat
Update docs/content/en/docs/getting-started/observability/_index.md
cd66ca6 
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: Meg McRoberts <mmcroberts@cloudbees.com>
@StackScribe
polishing install/integrate
35795a7 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe
markdownlint-fix
7556f16 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe
fix xref, add Grafana graphic
f638b19 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe
markdownlint-fix
11896a1 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
agardnerIT
agardnerIT previously approved these changes May 18, 2023
View reviewed changes
@StackScribe
remove otel-collector from list
e836ecf 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
agardnerIT
agardnerIT previously approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@agardnerIT agardnerIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy that this is in a good enough shape to merge now. We can, of course, add info + fix things in subsequent PRs.

I suggest merging so we don't have very valuable info sitting in PRs.

@StackScribe @odubajDT
Update docs/content/en/docs/getting-started/observability/_index.md
f3c37d9 
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Signed-off-by: Meg McRoberts <mmcroberts@cloudbees.com>
@StackScribe @odubajDT
Update docs/content/en/docs/getting-started/observability/_index.md
461d4c4 
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Signed-off-by: Meg McRoberts <mmcroberts@cloudbees.com>
StackScribe and others added 2 commits May 22, 2023 00:16
@StackScribe @thisthat
Update docs/content/en/docs/install/k8s.md
9c090fe 
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: Meg McRoberts <mmcroberts@cloudbees.com>
@StackScribe @odubajDT
Update docs/content/en/docs/getting-started/observability/_index.md
31908a1 
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Signed-off-by: Meg McRoberts <mmcroberts@cloudbees.com>
@sonarcloud
Copy link

sonarcloud bot commented May 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thisthat thisthat dismissed odubajDT’s stale review May 22, 2023 07:30

comments addressed. Further improvements will be done in a follow-up

thisthat
thisthat approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RealAnna
RealAnna approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can address my comments in a follow up

@StackScribe StackScribe merged commit 4815986 into keptn:main May 22, 2023
15 checks passed
@keptn-bot keptn-bot mentioned this pull request May 22, 2023
Merged
@thisthat thisthat mentioned this pull request May 22, 2023
Closed
@keptn-bot keptn-bot mentioned this pull request Jun 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agardnerIT agardnerIT agardnerIT left review comments

@thisthat thisthat thisthat approved these changes

@RealAnna RealAnna RealAnna approved these changes

@odubajDT odubajDT odubajDT left review comments

Assignees

@StackScribe StackScribe

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@StackScribe @thisthat @agardnerIT @RealAnna @odubajDT @aepfli