-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add configurable service account to KeptnTasks #2254
Conversation
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lifecycle-operator/controllers/lifecycle/keptntask/job_utils.go
Outdated
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2254 +/- ##
==========================================
- Coverage 85.50% 85.48% -0.02%
==========================================
Files 161 161
Lines 10166 10165 -1
==========================================
- Hits 8692 8690 -2
- Misses 1196 1197 +1
Partials 278 278
... and 6 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
hey @RealAnna, could you once review it so that I am able to know what subsequent changes require here ?? |
lifecycle-operator/controllers/lifecycle/keptntask/job_utils.go
Outdated
Show resolved
Hide resolved
lifecycle-operator/controllers/lifecycle/keptntask/job_utils.go
Outdated
Show resolved
Hide resolved
lifecycle-operator/controllers/lifecycle/keptntask/job_utils.go
Outdated
Show resolved
Hide resolved
@prakrit55 we have some helm tests based on the helm chart, you will have to fix them to add the new value in the crd |
lifecycle-operator/controllers/lifecycle/keptntask/job_utils.go
Outdated
Show resolved
Hide resolved
lifecycle-operator/controllers/lifecycle/keptntask/job_utils.go
Outdated
Show resolved
Hide resolved
lifecycle-operator/controllers/lifecycle/keptntask/job_utils.go
Outdated
Show resolved
Hide resolved
lifecycle-operator/controllers/lifecycle/keptntask/job_utils.go
Outdated
Show resolved
Hide resolved
lifecycle-operator/apis/lifecycle/v1alpha3/keptntaskdefinition_types.go
Outdated
Show resolved
Hide resolved
lifecycle-operator/apis/lifecycle/v1alpha3/keptntaskdefinition_types.go
Outdated
Show resolved
Hide resolved
lifecycle-operator/controllers/lifecycle/keptntask/job_utils_test.go
Outdated
Show resolved
Hide resolved
lifecycle-operator/controllers/lifecycle/keptntask/job_utils.go
Outdated
Show resolved
Hide resolved
lifecycle-operator/controllers/lifecycle/keptntask/job_utils.go
Outdated
Show resolved
Hide resolved
lifecycle-operator/controllers/lifecycle/keptntask/job_utils_test.go
Outdated
Show resolved
Hide resolved
lifecycle-operator/controllers/lifecycle/keptntask/job_utils_test.go
Outdated
Show resolved
Hide resolved
lifecycle-operator/controllers/lifecycle/keptntask/job_utils_test.go
Outdated
Show resolved
Hide resolved
lifecycle-operator/controllers/lifecycle/keptntask/job_utils_test.go
Outdated
Show resolved
Hide resolved
removed log line Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
Signed-off-by: Griffin <prakritimandal611@gmail.com>
Signed-off-by: Griffin <prakritimandal611@gmail.com>
Signed-off-by: Griffin <prakritimandal611@gmail.com>
Signed-off-by: Griffin <prakritimandal611@gmail.com>
Signed-off-by: Griffin <prakritimandal611@gmail.com>
Signed-off-by: Griffin <prakritimandal611@gmail.com>
configured test Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
updated job_utils_test.go Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
updated test parameters Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
Signed-off-by: Griffin <prakritimandal611@gmail.com>
377ca46
to
97ed2c4
Compare
done 👍 |
Nice job! :) |
lifecycle-operator/apis/lifecycle/v1alpha3/keptntaskdefinition_types.go
Outdated
Show resolved
Hide resolved
lifecycle-operator/apis/lifecycle/v1alpha3/keptntaskdefinition_types.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good already, thank you for that contribution :) I just left some suggestions to make the documentation a bit tidier, but once those have been incorporated and the auto generated docs have been regenerated I think this is ready to get merged!
modified comments Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
Signed-off-by: Griffin <prakritimandal611@gmail.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
fixes:#1869
spec.serviceAccount.name