Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lifecycle-operator): introduce a possibility to configure number of retries and interval for KeptnEvaluationDefinition #3141

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

odubajDT
Copy link
Contributor

Fixes: #3132

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.83%. Comparing base (17841c6) to head (7a483ab).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3141      +/-   ##
==========================================
- Coverage   86.88%   86.83%   -0.06%     
==========================================
  Files         162      162              
  Lines        8595     8597       +2     
==========================================
- Hits         7468     7465       -3     
- Misses        838      842       +4     
- Partials      289      290       +1     
Files Coverage Δ
...or/apis/lifecycle/v1beta1/keptnappversion_types.go 98.19% <100.00%> (+<0.01%) ⬆️
...or/apis/lifecycle/v1beta1/keptnevaluation_types.go 96.82% <ø> (ø)
...fecycle/v1beta1/keptnevaluationdefinition_types.go 100.00% <ø> (ø)
...operator/apis/lifecycle/v1beta1/keptntask_types.go 97.29% <ø> (ø)
...is/lifecycle/v1beta1/keptnworkloadversion_types.go 96.26% <100.00%> (+0.01%) ⬆️

... and 4 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 69.23% <ø> (ø)
component-tests 57.21% <ø> (-1.03%) ⬇️
lifecycle-operator 86.46% <100.00%> (+<0.01%) ⬆️
metrics-operator 88.32% <ø> (ø)
scheduler 34.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions github-actions bot added documentation Improvements or additions to documentation ops labels Feb 28, 2024
… of retries and interval for KeptnEvaluationDefinition

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT odubajDT marked this pull request as ready for review February 29, 2024 11:55
@odubajDT odubajDT requested review from a team as code owners February 29, 2024 11:55
RealAnna
RealAnna previously approved these changes Feb 29, 2024
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would assume that some docs and examples also need to be adjusted with this change

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@odubajDT odubajDT merged commit 65f7327 into keptn:main Feb 29, 2024
43 checks passed
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
… of retries and interval for KeptnEvaluationDefinition (keptn#3141)

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: vickysomtee <vickysomtee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lifecycle-operator ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce a possibility to configure number of retries and interval for KeptnEvaluationDefinition
3 participants