Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(helm-chart): ability to set hostNetwork for lifecycle operator deployment #3500

Merged
merged 5 commits into from
May 13, 2024
Merged

feat(helm-chart): ability to set hostNetwork for lifecycle operator deployment #3500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9fce595
Add the ability to set hostNetwork for lifecycle operator deployment
May 7, 2024
25d6c15
Add `hostNetwork` value in result.yaml's for helm-tests
May 7, 2024
d91ada9
Update helm docs
May 7, 2024
35e72c0
add hostNetwork parameter to the deployment config
JLont May 8, 2024
e312efc
Add test scenario for hostNetwork true
JLont May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/scripts/.helm-tests/Openshift/result.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15419,6 +15419,7 @@ spec:
runAsNonRoot: true
serviceAccountName: lifecycle-operator
terminationGracePeriodSeconds: 10
hostNetwork: false
volumes:
- name: keptn-certs
secret:
Expand Down
1 change: 1 addition & 0 deletions .github/scripts/.helm-tests/default/result.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15423,6 +15423,7 @@ spec:
runAsNonRoot: true
serviceAccountName: lifecycle-operator
terminationGracePeriodSeconds: 10
hostNetwork: false
volumes:
- name: keptn-certs
secret:
Expand Down
1 change: 1 addition & 0 deletions .github/scripts/.helm-tests/lifecycle-only/result.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11989,6 +11989,7 @@ spec:
runAsNonRoot: true
serviceAccountName: lifecycle-operator
terminationGracePeriodSeconds: 10
hostNetwork: true
volumes:
- name: keptn-certs
secret:
Expand Down
1 change: 1 addition & 0 deletions .github/scripts/.helm-tests/lifecycle-only/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ lifecycleOperator:
repository: busybox
tag: 1.35
imagePullPolicy: Always
hostNetwork: true
scheduler:
image:
tag: v0.0.0
Expand Down
1 change: 1 addition & 0 deletions .github/scripts/.helm-tests/lifecycle-with-certs/result.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12290,6 +12290,7 @@ spec:
runAsNonRoot: true
serviceAccountName: lifecycle-operator
terminationGracePeriodSeconds: 10
hostNetwork: false
odubajDT marked this conversation as resolved.
Show resolved Hide resolved
volumes:
- name: keptn-certs
secret:
Expand Down
1 change: 1 addition & 0 deletions .github/scripts/.helm-tests/local-global-precedence/result.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15751,6 +15751,7 @@ spec:
runAsNonRoot: true
serviceAccountName: lifecycle-operator
terminationGracePeriodSeconds: 10
hostNetwork: false
volumes:
- name: keptn-certs
secret:
Expand Down
1 change: 1 addition & 0 deletions lifecycle-operator/chart/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ and application health checks
| `lifecycleOperator.replicas` | customize number of installed lifecycle operator replicas | `1` |
| `lifecycleOperator.tolerations` | add custom tolerations to lifecycle operator | `[]` |
| `lifecycleOperator.topologySpreadConstraints` | add custom topology constraints to lifecycle operator | `[]` |
| `lifecycleOperator.hostNetwork` | Sets hostNetwork option for lifecycle operator | `false` |
| `lifecycleOperatorMetricsService` | Adjust settings here to change the k8s service for scraping Prometheus metrics | |

### Global
Expand Down
1 change: 1 addition & 0 deletions lifecycle-operator/chart/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ spec:
runAsNonRoot: true
serviceAccountName: lifecycle-operator
terminationGracePeriodSeconds: 10
hostNetwork: {{ .Values.lifecycleOperator.hostNetwork }}
volumes:
- name: keptn-certs
secret:
Expand Down
2 changes: 2 additions & 0 deletions lifecycle-operator/chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,8 @@ lifecycleOperator:
tolerations: []
## @param lifecycleOperator.topologySpreadConstraints add custom topology constraints to lifecycle operator
topologySpreadConstraints: []
## @param lifecycleOperator.hostNetwork Sets hostNetwork option for lifecycle operator
hostNetwork: false
## @extra lifecycleOperatorMetricsService Adjust settings here to change the k8s service for scraping Prometheus metrics
## @skip lifecycleOperatorMetricsService.ports[0].name
## @skip lifecycleOperatorMetricsService.ports[0].port
Expand Down
1 change: 1 addition & 0 deletions lifecycle-operator/config/manager/manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ spec:
memory: 64Mi
serviceAccountName: lifecycle-operator
terminationGracePeriodSeconds: 10
hostNetwork: false
volumes:
- name: keptn-certs
secret:
Expand Down
Loading