Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): helm values overide format and dashboard fix #3562

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

suzi1037
Copy link
Contributor

@suzi1037 suzi1037 commented Jun 21, 2024

  1. helm value overide:
    sidecar.datasources.defaultDatasourceEnabled: false
    this format has no effect, should be like
  sidecar:
    datasources:
      defaultDatasourceEnabled: false
  1. dashboard label
    grafana_dashboard should be "1"

grafana-sc-dashboard containers watch
- name: LABEL
value: "grafana_dashboard"
- name: LABEL_VALUE
value: "1"

with lable=0 currently, follow the document example deployment, Grafana will not have the corresponding Dashboard.

…label

Signed-off-by: suzi1037 <xiaoxin09@hotmail.com>
@suzi1037 suzi1037 requested review from a team as code owners June 21, 2024 07:09
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 21, 2024
@suzi1037 suzi1037 changed the title fix(examples-observability): helm values overide format && dashboard … fix(examples): helm values overide format && dashboard … Jun 21, 2024
@odubajDT odubajDT changed the title fix(examples): helm values overide format && dashboard … fix(examples): helm values overide format and dashboard fix Jun 26, 2024
@odubajDT odubajDT merged commit f5a820f into keptn:main Jun 27, 2024
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants