Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(operator): revert broken OTel version #447

Merged
merged 2 commits into from
Nov 22, 2022
Merged

fix(operator): revert broken OTel version #447

merged 2 commits into from
Nov 22, 2022

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Nov 21, 2022

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #447 (7e83345) into main (19114db) will increase coverage by 3.59%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
+ Coverage   34.39%   37.99%   +3.59%     
==========================================
  Files          23       28       +5     
  Lines        1820     2082     +262     
==========================================
+ Hits          626      791     +165     
- Misses       1145     1227      +82     
- Partials       49       64      +15     
Impacted Files Coverage Δ
operator/controllers/common/spanhandler.go 78.57% <0.00%> (ø)
operator/controllers/common/test_utils.go 0.00% <0.00%> (ø)
...ers/keptnappversion/reconcile_prepostdeployment.go 81.25% <0.00%> (ø)
operator/controllers/keptnappversion/controller.go 71.87% <0.00%> (ø)
...ollers/keptnappversion/reconcile_workloadsstate.go 47.72% <0.00%> (ø)
...ers/keptnappversion/reconcile_prepostevaluation.go 81.25% <0.00%> (ø)
Flag Coverage Δ
keptn-lifecycle-operator 41.96% <ø> (+3.44%) ⬆️
scheduler 4.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
2.9% 2.9% Duplication

@odubajDT odubajDT marked this pull request as ready for review November 21, 2022 13:41
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics exported with wrong name (keptn_app_count_total)
3 participants