Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(operator): restructure packages #469

Merged
merged 3 commits into from
Nov 28, 2022
Merged

chore(operator): restructure packages #469

merged 3 commits into from
Nov 28, 2022

Conversation

odubajDT
Copy link
Contributor

Signed-off-by: odubajDT ondrej.dubaj@dynatrace.com

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #469 (7094d72) into main (21b4d5d) will increase coverage by 8.13%.
The diff coverage is 74.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
+ Coverage   51.49%   59.63%   +8.13%     
==========================================
  Files          28       28              
  Lines        2101     2101              
==========================================
+ Hits         1082     1253     +171     
+ Misses        920      744     -176     
- Partials       99      104       +5     
Impacted Files Coverage Δ
...ator/controllers/interfaces/activemetricsobject.go 70.00% <0.00%> (ø)
operator/controllers/interfaces/listitem.go 62.50% <0.00%> (ø)
operator/controllers/interfaces/metricsobject.go 86.36% <0.00%> (ø)
operator/controllers/interfaces/spanitem.go 78.57% <0.00%> (ø)
operator/controllers/keptnapp/controller.go 77.64% <0.00%> (+11.76%) ⬆️
operator/controllers/keptntask/function_utils.go 77.77% <25.00%> (ø)
operator/controllers/keptntask/controller.go 53.93% <50.00%> (+53.93%) ⬆️
...keptnworkloadinstance/reconcile_deploymentstate.go 62.29% <50.00%> (ø)
...ollers/keptnappversion/reconcile_workloadsstate.go 47.72% <57.14%> (ø)
operator/controllers/common/evaluationhandler.go 78.63% <66.66%> (+5.98%) ⬆️
... and 24 more
Flag Coverage Δ
component-tests 51.96% <52.12%> (?)
keptn-lifecycle-operator 56.64% <60.84%> (-0.38%) ⬇️
scheduler 4.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT odubajDT changed the title chore(operator): Restructure packages chore(operator): restructure packages Nov 28, 2022
@odubajDT odubajDT marked this pull request as ready for review November 28, 2022 10:31
RealAnna
RealAnna previously approved these changes Nov 28, 2022
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
2.7% 2.7% Duplication

Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odubajDT odubajDT merged commit 41f21eb into keptn:main Nov 28, 2022
@keptn-bot keptn-bot mentioned this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants