Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(operator): introduce KeptnMetrics CRD and controller #643

Merged
merged 14 commits into from
Jan 18, 2023
Merged

feat(operator): introduce KeptnMetrics CRD and controller #643

merged 14 commits into from
Jan 18, 2023

Conversation

odubajDT
Copy link
Contributor

Signed-off-by: odubajDT ondrej.dubaj@dynatrace.com

Fixes: #602

@codecov
Copy link

codecov bot commented Jan 18, 2023 •
edited
Loading

Codecov Report

Merging #643 (3daf7fa) into main (752ea58) will decrease coverage by 0.33%.
The diff coverage is 0.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #643      +/-   ##
==========================================
- Coverage   54.72%   54.40%   -0.33%     
==========================================
  Files          78       79       +1     
  Lines        6516     6533      +17     
==========================================
- Hits         3566     3554      -12     
- Misses       2799     2828      +29     
  Partials      151      151
Impacted Files Coverage Δ
...ator/controllers/metrics/keptnmetric_controller.go 0.00% <0.00%> (ø)
...ptnworkloadinstance/reconcile_prepostevaluation.go 72.72% <0.00%> (-9.10%) ⬇️
...ator/controllers/lifecycle/keptntask/controller.go 53.93% <0.00%> (-3.38%) ⬇️
...lers/lifecycle/keptnworkloadinstance/controller.go 74.07% <0.00%> (-2.78%) ⬇️
operator/controllers/common/evaluationhandler.go 77.53% <0.00%> (-2.18%) ⬇️
...ptnworkloadinstance/reconcile_prepostdeployment.go 90.90% <0.00%> (+9.09%) ⬆️
Flag Coverage Δ
component-tests 51.78% <ø> (-1.60%) ⬇️
keptn-cert-manager 67.56% <ø> (ø)
keptn-lifecycle-operator 51.98% <0.00%> (-0.16%) ⬇️
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT
feat(operator): introduce KeptnMetrics CRD and controller
2f1e845 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
fix tests
aae6e12 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
fix after rebase
47bf852 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
use []byte instead of string for raw valuaes
ffb65ba 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
add integration tests
afbd5c6 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
mowies
mowies reviewed Jan 18, 2023
View reviewed changes
test/integration/metrics/00-assert.yaml Outdated Show resolved Hide resolved
test/integration/metrics/00-install.yaml Outdated Show resolved Hide resolved
test/integration/metrics/00-teststep.yaml Outdated Show resolved Hide resolved
operator/config/crd/patches/cainjection_in_metrics_keptnmetrics.yaml Outdated Show resolved Hide resolved
operator/go.mod Outdated Show resolved Hide resolved
operator/apis/metrics/v1alpha1/keptnmetric_types.go Outdated Show resolved Hide resolved
operator/apis/metrics/v1alpha1/keptnmetric_types.go Outdated Show resolved Hide resolved
@odubajDT odubajDT marked this pull request as ready for review January 18, 2023 11:17
@odubajDT
pr review
9d6c045 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
odubajDT and others added 5 commits January 18, 2023 13:00
@odubajDT @mowies
Update operator/apis/metrics/v1alpha1/keptnmetric_types.go
7cbb3e7 
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
@odubajDT @mowies
Update operator/apis/metrics/v1alpha1/keptnmetric_types.go
40ddb30 
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
@odubajDT
pr review 2
65c2b9e 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
giovanni happy
628bfee 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
final
dd5787d 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT odubajDT requested a review from mowies January 18, 2023 13:12
@odubajDT
fix main
28364c4 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
make Anna happy
089d25f 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
final fix
3daf7fa 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odubajDT odubajDT merged commit 96170df into keptn:main Jan 18, 2023
@keptn-bot keptn-bot mentioned this pull request Jan 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bacherfl bacherfl bacherfl approved these changes

@RealAnna RealAnna RealAnna approved these changes

@thisthat thisthat Awaiting requested review from thisthat

@thschue thschue Awaiting requested review from thschue

@mowies mowies Awaiting requested review from mowies

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Boostrap new controller for Keptn Metrics
4 participants
@odubajDT @bacherfl @mowies @RealAnna