Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use helm charts instead of manifests + document KeptnConfig CRD #747

Merged
merged 5 commits into from
Mar 8, 2023
Merged

docs: use helm charts instead of manifests + document KeptnConfig CRD #747

merged 5 commits into from
Mar 8, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Feb 2, 2023

Signed-off-by: odubajDT ondrej.dubaj@dynatrace.com

Fixes: #597

PLEASE do not merge this until we do not have a first version of helm-charts released

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #747 (00305b9) into main (59ee362) will decrease coverage by 0.74%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #747      +/-   ##
==========================================
- Coverage   57.81%   57.07%   -0.74%     
==========================================
  Files         122      104      -18     
  Lines       10095     9014    -1081     
==========================================
- Hits         5836     5145     -691     
+ Misses       4051     3694     -357     
+ Partials      208      175      -33     
Impacted Files Coverage Δ
metrics-operator/cmd/webhook/manager.go
...ics-operator/api/v1alpha1/zz_generated.deepcopy.go
metrics-operator/pkg/metrics/server.go
metrics-operator/api/v1alpha1/keptnmetric_types.go
...ollers/common/providers/dynatrace/client/config.go
...trics-operator/api/v1alpha2/keptnmetric_webhook.go
...ollers/common/providers/dynatrace/dynatrace_dql.go
...-operator/controllers/common/providers/provider.go
...ics-operator/api/v1alpha2/zz_generated.deepcopy.go
metrics-operator/cmd/webhook/builder.go
... and 16 more
Flag Coverage Δ
certificate-operator 64.15% <ø> (ø)
component-tests 53.12% <ø> (+0.05%) ⬆️
lifecycle-operator 53.63% <ø> (ø)
metrics-operator ?
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@aepfli aepfli added the documentation Improvements or additions to documentation label Mar 1, 2023
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. I left a few editorial suggestions and one structural suggestion for your consideration.

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@netlify
Copy link

netlify bot commented Mar 7, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 00305b9
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64084fcd2bdbb0000812801d
😎 Deploy Preview https://deploy-preview-747--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@odubajDT odubajDT marked this pull request as ready for review March 7, 2023 14:50
examples/Makefile Outdated Show resolved Hide resolved
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
RealAnna
RealAnna previously approved these changes Mar 7, 2023
README.md Outdated Show resolved Hide resolved
docs/CONTRIBUTING.md Outdated Show resolved Hide resolved
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
bacherfl
bacherfl previously approved these changes Mar 8, 2023
@odubajDT odubajDT requested a review from thisthat March 8, 2023 08:49
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.9% 2.9% Duplication

@odubajDT odubajDT requested a review from thisthat March 8, 2023 09:07
@odubajDT odubajDT merged commit 338c0fa into keptn:main Mar 8, 2023
@keptn-bot keptn-bot mentioned this pull request Mar 8, 2023
@keptn-bot keptn-bot mentioned this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt docs to use helm chart instead of manifests
6 participants