Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: modify getting-started.md #768

Merged
merged 1 commit into from
Feb 6, 2023
Merged

docs: modify getting-started.md #768

merged 1 commit into from
Feb 6, 2023

Conversation

rakshitgondwal
Copy link
Member

Signed-off-by: Rakshit Gondwal rakshitgondwal3@gmail.com

Fixed some typo's and some grammatical errors.

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #768 (c2c3fb3) into main (ce6b7f0) will decrease coverage by 0.70%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #768      +/-   ##
==========================================
- Coverage   57.75%   57.06%   -0.70%     
==========================================
  Files          91       83       -8     
  Lines        7243     6763     -480     
==========================================
- Hits         4183     3859     -324     
+ Misses       2891     2777     -114     
+ Partials      169      127      -42     
Impacted Files Coverage Δ
klt-cert-manager/kubeutils/secret.go
...anager/controllers/keptnwebhookcontroller/certs.go
...rs/keptnwebhookcontroller/webhook_configuration.go
...okcontroller/keptnwebhookcertificate_controller.go
...llers/keptnwebhookcontroller/certificate_secret.go
klt-cert-manager/kubeutils/query.go
klt-cert-manager/eventfilter/eventfilter.go
klt-cert-manager/kubeutils/certificates.go
Flag Coverage Δ
klt-cert-manager ?
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Thomas Schuetz <thomas.schuetz@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! LGTM

@thschue thschue merged commit f2263b5 into keptn:main Feb 6, 2023
@keptn-bot keptn-bot mentioned this pull request Feb 6, 2023
@rakshitgondwal rakshitgondwal deleted the dev3 branch March 27, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants