Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add Netlify configuration and advanced build #892

Merged
merged 9 commits into from
Feb 28, 2023
Merged

docs: add Netlify configuration and advanced build #892

merged 9 commits into from
Feb 28, 2023

Conversation

aepfli
Copy link
Member

@aepfli aepfli commented Feb 21, 2023 •
edited by mowies
Loading

@aepfli aepfli force-pushed the improve_website_build_2 branch 6 times, most recently from f98fd85 to 6b4b681 Compare February 21, 2023 16:16
@aepfli aepfli changed the title Improve website build 2 docs: Improve website build 2 Feb 21, 2023
@aepfli aepfli changed the title docs: Improve website build 2 docs: Adding Netlify configuration and advanced build (#798) Feb 21, 2023
@codecov
Copy link

codecov bot commented Feb 21, 2023 •
edited
Loading

Codecov Report

Merging #892 (2aa2d15) into main (ba700a7) will increase coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #892      +/-   ##
==========================================
+ Coverage   58.60%   58.67%   +0.06%     
==========================================
  Files          97       97              
  Lines        7552     7552              
==========================================
+ Hits         4426     4431       +5     
+ Misses       2935     2932       -3     
+ Partials      191      189       -2
Impacted Files Coverage Δ
...lers/lifecycle/keptnworkloadinstance/controller.go 82.51% <0.00%> (-0.45%) ⬇️
...ator/controllers/lifecycle/keptntask/controller.go 58.24% <0.00%> (+3.29%) ⬆️
...ptnworkloadinstance/reconcile_prepostdeployment.go 90.90% <0.00%> (+9.09%) ⬆️
Flag Coverage Δ
component-tests 42.06% <ø> (-0.14%) ⬇️
keptn-lifecycle-operator 54.67% <ø> (ø)
klt-cert-manager 67.50% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@aepfli aepfli changed the title docs: Adding Netlify configuration and advanced build (#798) docs: adding Netlify configuration and advanced build (#798) Feb 21, 2023
@aepfli aepfli force-pushed the improve_website_build_2 branch 2 times, most recently from 74dc24e to 000b2f0 Compare February 21, 2023 16:30
@netlify
Copy link

netlify bot commented Feb 21, 2023 •
edited
Loading

✅ Deploy Preview for keptn-lifecyle-testing ready!

Name Link
🔨 Latest commit 7df84c7
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecyle-testing/deploys/63f62af448a806000872ba6e
😎 Deploy Preview https://deploy-preview-892--keptn-lifecyle-testing.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mowies mowies changed the title docs: adding Netlify configuration and advanced build (#798) docs: adding Netlify configuration and advanced build Feb 22, 2023
@mowies mowies changed the title docs: adding Netlify configuration and advanced build docs: add Netlify configuration and advanced build Feb 22, 2023
@aepfli
docs: add Netlify configuration and apply advanced doc build (keptn#798)
2b3f713 
Added Netlify documentation and basic setup for documentation build.

relates: keptn#798

Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
@aepfli
removing unneeded line
8690d00 
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
@aepfli aepfli force-pushed the improve_website_build_2 branch 5 times, most recently from efa8544 to c43910e Compare February 22, 2023 14:09
@aepfli aepfli marked this pull request as ready for review February 22, 2023 14:10
@aepfli aepfli force-pushed the improve_website_build_2 branch 8 times, most recently from 5752270 to 9021765 Compare February 23, 2023 13:45
@aepfli
PR Changes and requests
ef58356 
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
mowies
mowies reviewed Feb 23, 2023
View reviewed changes
netlify.toml Show resolved Hide resolved
docs/config/production/params.yaml Outdated Show resolved Hide resolved
.github/workflows/release-docs.yml Show resolved Hide resolved
aepfli and others added 3 commits February 26, 2023 08:42
@aepfli
Apply suggestions from code review
47e5f68 
Signed-off-by: Simon Schrottner <simon.schrottner@gmail.com>
@aepfli
Pr Changes
a02f72f 
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
@aepfli
Adding renovate configuration
fce21d6 
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
@mowies @aepfli
Update docs/config/production/params.yaml
5cf43a3 
Co-authored-by: Simon Schrottner <simon.schrottner@gmail.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
mowies
mowies previously approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aepfli
adding go mod file
2aa2d15 
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

thisthat
thisthat approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aepfli aepfli merged commit 81cd1f2 into keptn:main Feb 28, 2023
@aepfli aepfli mentioned this pull request Mar 1, 2023
Closed
10 tasks
aepfli added a commit to aepfli/lifecycle-toolkit that referenced this pull request Mar 1, 2023
@aepfli @mowies
docs: add Netlify configuration and advanced build (keptn#892)
825ae0f 
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@keptn-bot keptn-bot mentioned this pull request Mar 1, 2023
Merged
aepfli added a commit to aepfli/lifecycle-toolkit that referenced this pull request Mar 3, 2023
@aepfli @mowies
docs: add Netlify configuration and advanced build (keptn#892)
8efdef2 
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@keptn-bot keptn-bot mentioned this pull request Mar 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisthat thisthat thisthat approved these changes

@mowies mowies mowies approved these changes

@thschue thschue Awaiting requested review from thschue

@bacherfl bacherfl Awaiting requested review from bacherfl

@StackScribe StackScribe Awaiting requested review from StackScribe

@philipp-hinteregger philipp-hinteregger Awaiting requested review from philipp-hinteregger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aepfli @thisthat @mowies