Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Spec change for evaluation-done: Add new field that contains the compared event ids #42

Closed
christian-kreuzberger-dtx opened this issue Sep 25, 2020 · 0 comments · Fixed by #43
Closed

Spec change for evaluation-done: Add new field that contains the compared event ids #42

christian-kreuzberger-dtx opened this issue Sep 25, 2020 · 0 comments · Fixed by #43
Assignees
@bacherfl

Comments

@christian-kreuzberger-dtx
Copy link
Member

In keptn/keptn#2388 (PR keptn/keptn#2394 ) we have introduced a new field in the evaluation-done cloud-event that contains all evaluation-done events that we compare with.

This needs to be reflected in the spec: https://github.com/keptn/spec/blob/master/cloudevents.md#evaluation-done
@christian-kreuzberger-dtx christian-kreuzberger-dtx changed the title Spec change for evaluation-done: Add Spec change for evaluation-done: Add new field that contains the compared event ids Sep 28, 2020
@johannes-b johannes-b assigned johannes-b and unassigned johannes-b Sep 30, 2020
@bacherfl bacherfl self-assigned this Sep 30, 2020
bacherfl added a commit that referenced this issue Sep 30, 2020
@bacherfl
#42 Added comparedEvents to evaluation-done spec
a8d54bd
@bacherfl bacherfl mentioned this issue Sep 30, 2020
Merged
johannes-b pushed a commit that referenced this issue Sep 30, 2020
@bacherfl
#42 Added comparedEvents to evaluation-done spec (#43)
d7b0e4c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bacherfl bacherfl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#42 Added comparedEvents to evaluation-done spec keptn/spec
3 participants
@johannes-b @bacherfl @christian-kreuzberger-dtx