Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "masks" and "boxes" as prompt keys for SAM #2084

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

ianstenbit
Copy link
Contributor

Even though these inputs only accept 1 input per image, we use plurals as our standard for input keys in KerasCV (take, for example, "images", which is plural even though there is only 1 input image per batch)

cc @tirthasheshpatel

@ianstenbit
Copy link
Contributor Author

/gcbrun

Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ianstenbit ianstenbit merged commit 394d087 into keras-team:master Sep 22, 2023
8 of 9 checks passed
@ianstenbit ianstenbit deleted the sam-input-names branch September 22, 2023 18:09
ghost pushed a commit to y-vectorfield/keras-cv that referenced this pull request Nov 16, 2023
* Use "masks" and "boxes" as prompt keys for SAM

* Fix tests
yuvraj-wale pushed a commit to yuvraj-wale/keras-cv that referenced this pull request Feb 8, 2024
* Use "masks" and "boxes" as prompt keys for SAM

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants