Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc updates to switch branding to Keras 3 #2092

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

ianstenbit
Copy link
Contributor

@ianstenbit ianstenbit commented Sep 28, 2023

Shamelessly copied from @mattdangerw's PR on KerasNLP

Keeping as a draft until that PR is merged.

Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just the one comment we already discussed offline.

README.md Outdated

> [!IMPORTANT]
> If you want to import Keras and guarantee that you're getting the same version
> that KerasCV is using, just use `from keras_cv.backend import keras`. This
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not use this, as it is not available in our exported API, or would be only via from keras_cv.src.backend import keras.

@ianstenbit ianstenbit marked this pull request as ready for review October 6, 2023 19:59
@ianstenbit ianstenbit merged commit 9cf9c88 into keras-team:master Oct 6, 2023
6 of 9 checks passed
@ianstenbit ianstenbit deleted the keras-3-docs branch October 6, 2023 21:21
ghost pushed a commit to y-vectorfield/keras-cv that referenced this pull request Nov 16, 2023
* Update README

* Fix imports in docs

* Update keras import instructions
yuvraj-wale pushed a commit to yuvraj-wale/keras-cv that referenced this pull request Feb 8, 2024
* Update README

* Fix imports in docs

* Update keras import instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants