Add documentation for Model._make_predict_function #13116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchollet
reviewed
Jul 25, 2019
| Note: the internal prediction function is not compiled until the first | ||
| call to `Model.predict`. If you are using `Model.predict` in a | ||
| multi-threaded environment, you should explicitly call | ||
| `Model._make_predict_function` first to avoid problems. |
There was a problem hiding this comment.
_make_predict_function is a private API. We should not recommend calling it.
Here, the user should simply call predict first.
Note that Keras models can't be guaranteed to be thread-safe. Consider having independent copies of the model in each thread for CPU inference.
mihajenko
pushed a commit
to mihajenko/ivis
that referenced
this pull request
May 5, 2020
Discussions on why it isn't recommended to call: * keras-team/keras#6124 * keras-team/keras#13116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This documents the
keras.Model._make_predict_functionmethod, which is necessary forkeras.Model.predictto function correctly in threads.Related Issues
Lots of people were looking for documentation on this function and could not find it. See this issue:
#6124
and this stack overflow thread:
https://stackoverflow.com/a/43393252
PR Overview