-
Notifications
You must be signed in to change notification settings - Fork 19.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve truncated normal issues #9957
Conversation
Thanks for the PR. This would be a breaking behavior change, so we won't merge it. In general it is preferable to align the behavior of backend functions on the corresponding TF functions. If the docstring is misleading, we can fix the docstring. What we can do, is merge your fix for Theano (since a different behavior for Theano would be a bug), and add a unit test checking that the distributions are equivalent across the different backends. |
Changing the documentation of the backend functions would be a good idea indeed (this is also how tensorflow handled this issue), because, in my eyes, the option to provide standard deviation as a parameter to a distribution, implies that the returned distribution has the given standard deviation. In the case that In order for the initializers to finally work correctly, I do think it is important to fix See #9963 for this alternative fix |
Attempt to implement the fix for the issue with truncated normal as discussed in #8048