Add password score endpoint #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cainlevy
approved these changes
Feb 9, 2020
There was a problem hiding this comment.
Makes sense to me! We did notice a difference in zxcvbn libraries once.
Would you add an entry to docs/api.md and a mention in docs/guide-displaying_a_password_strength_meter.md?
So sorry, forgot the docs again 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add endpoint for checking password's zxcvbn score
Motivation
Having to use a client JS library to check for password score adds almost 800kb payload that has to be downloaded by the user. Even though registration happens only once, having to download this amount of data on a sometimes slower mobile connection could very much frustrate users. Moving this check to the backend also ensures that the algorithm (and dictionaries used for the zxcvbn) is the same.