-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/improve output on errors #482
Merged
paulo-ferraz-oliveira
merged 24 commits into
kerl:master
from
paulo-ferraz-oliveira:fix/improve-output-on-error
Oct 26, 2023
Merged
Changes from 22 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
0cabd97
Remove return/exit distinctions where not used
paulo-ferraz-oliveira 31f1bcf
Update .kerl/otp_releases inplace
paulo-ferraz-oliveira 0f23603
Fail louder
paulo-ferraz-oliveira 403eca4
Error out on assertion site, not call site
paulo-ferraz-oliveira 06c149a
Use less return/exit indirections
paulo-ferraz-oliveira f385275
Prevent return+exit in same function/scope
paulo-ferraz-oliveira df81849
Simplify `kerl active`
paulo-ferraz-oliveira 6079a69
Add to current execution logging
paulo-ferraz-oliveira e139d49
Centralize curl calls to ease debug logging
paulo-ferraz-oliveira 04cc564
Act on self-review: name flag more explicitly
paulo-ferraz-oliveira 479e5d3
Act on self-review: add README note on how otp_releases is built
paulo-ferraz-oliveira 70a37c8
Act on self-review: don't assume files aren't somehow protected
paulo-ferraz-oliveira fde8ee5
Act on self-review: ease maintenance of do_build function return
paulo-ferraz-oliveira b2a56c3
Act on local tests: silence tee
paulo-ferraz-oliveira cf21ba3
Act on self-review: be consistent in punctuation
paulo-ferraz-oliveira 785f984
Act on self-review: run all CI elements with KERL_DEBUG=yes
paulo-ferraz-oliveira ff6bd1b
Act on local test results: don't output ".:" when outputting errors
paulo-ferraz-oliveira a256167
Act on CI results: truthy value should be one of [false, true]
paulo-ferraz-oliveira e71bef8
Act on CI results: don't have CI fail with a new exit code
paulo-ferraz-oliveira f09a628
Act on CI results: prevent "indication of CI" from breaking script
paulo-ferraz-oliveira f5150bc
Act on CI results: validate activation in a correct shell scope
paulo-ferraz-oliveira 841284c
Act on CI results: choose warn instead error, sometimes
paulo-ferraz-oliveira f7fcb26
Act on review comment: Kerl > `kerl`
paulo-ferraz-oliveira 8b1c6ab
Act on review comment: all _curl calls are GETs for now
paulo-ferraz-oliveira File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kerl
no uppercasing pleaseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. It was there already, so I took "advantage" of that. Maybe I'll take this chance to lowercase it all, then (?)
Edit: apparently also by me 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f7fcb26